[Bug 3223] New: insmod/modprobe incorrectly parses several parameters in kernel 2.4

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=3223

            Target: linux 2.4
           Summary: insmod/modprobe incorrectly parses several parameters
                    in kernel 2.4
           Product: Busybox
           Version: 1.18.x
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: major
          Priority: P3
         Component: Other
        AssignedTo: unassigned at busybox.net
        ReportedBy: lly.dev at gmail.com
                CC: busybox-cvs at busybox.net
   Estimated Hours: 0.0


Created attachment 2953
  --> https://bugs.busybox.net/attachment.cgi?id=2953
Proposed patch

insmod/modprobe incorrectly parses several char & string parameters in kernel
2.4

Sample output:

# insmod netconsole.o netconsole=@/, at 192.168.1.100/
insmod: parameter netconsole requires at least 2 arguments

# modinfo netconsole.o 
filename:       netconsole.o
parm_desc_netconsole:
netconsole=[src-port]@[src-ip]/[dev],[tgt-port]@<tgt-ip>/[tgt-macaddr]

parm_netconsole:2s
license:        GPL
description:    Network console driver
author:         Maintainer: Herbert P�tzl <herbert at 13thfloor.at>
kernel_version: 2.4.37.11


This happens due to "Parse parameter values" loop in modutils-24.c:
new_process_module_arguments() wants to recheck ',' delimiter at the end of
switch (*pinfo), but it already overwritten by '\0' symbol in code above for
's' & 'c' cases.

Patch attached solves problem for me.

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.