[git commit master 1/1] login: free fromhost upon cleaning up

Denys Vlasenko vda.linux at googlemail.com
Thu Oct 28 03:49:55 UTC 2010


commit: http://git.busybox.net/busybox/commit/?id=78b286fea51ef137d660b91037c89376115a1994
branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master

Signed-off-by: Alexander Shishkin <virtuoso at slind.org>
Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 loginutils/login.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/loginutils/login.c b/loginutils/login.c
index e104fbb..3065eaa 100644
--- a/loginutils/login.c
+++ b/loginutils/login.c
@@ -364,6 +364,10 @@ int login_main(int argc UNUSED_PARAM, char **argv)
 		if (++count == 3) {
 			syslog(LOG_WARNING, "invalid password for '%s'%s",
 						username, fromhost);
+
+			if (ENABLE_FEATURE_CLEAN_UP)
+				free(fromhost);
+
 			return EXIT_FAILURE;
 		}
 		username[0] = '\0';
@@ -401,6 +405,9 @@ int login_main(int argc UNUSED_PARAM, char **argv)
 	if (pw->pw_uid == 0)
 		syslog(LOG_INFO, "root login%s", fromhost);
 
+	if (ENABLE_FEATURE_CLEAN_UP)
+		free(fromhost);
+
 	/* well, a simple setexeccon() here would do the job as well,
 	 * but let's play the game for now */
 	IF_SELINUX(set_current_security_context(user_sid);)
-- 
1.7.1



More information about the busybox-cvs mailing list