[git commit master 1/1] ip: Fix command line option parsing of "ip route get ..."

Denys Vlasenko vda.linux at googlemail.com
Thu Nov 4 07:59:42 UTC 2010


commit: http://git.busybox.net/busybox/commit/?id=3bbfb58bec18990a2ee93f31ea1ee2fd19c4d9b2
branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master

I found and fixed a bug in the command line options parsing of "ip route get":
It was impossible to get any option other than the IP address
recognized correctly, and e.g. the command "ip route get connected"
just hung up infinitely in the options parsing loop instead of
printing an error message.

Signed-off-by: Christian Hornung <chhornung at googlemail.com>
Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 networking/libiproute/iproute.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/networking/libiproute/iproute.c b/networking/libiproute/iproute.c
index f66774a..f6071b4 100644
--- a/networking/libiproute/iproute.c
+++ b/networking/libiproute/iproute.c
@@ -788,8 +788,8 @@ static int iproute_get(char **argv)
 				}
 				req.r.rtm_dst_len = addr.bitlen;
 			}
-			argv++;
 		}
+		argv++;
 	}
 
 	if (req.r.rtm_dst_len == 0) {
-- 
1.7.1



More information about the busybox-cvs mailing list