[git commit master 1/1] crond: mention other cronds' behavior in comment. no code changes

Denys Vlasenko vda.linux at googlemail.com
Sun Jul 11 21:20:15 UTC 2010


commit: http://git.busybox.net/busybox/commit/?id=69d69e2cb898f77827d2cf2c06a7f6fcd5157567
branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 miscutils/crond.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/miscutils/crond.c b/miscutils/crond.c
index a459c6a..66110bb 100644
--- a/miscutils/crond.c
+++ b/miscutils/crond.c
@@ -304,13 +304,15 @@ static void FixDayDow(CronLine *line)
 //if crontab was reloaded: crond thinks that "new" job is different from "old"
 //even if they are in fact completely the same. Example
 //Crontab was:
-// 0-59 * * * job1
-// 0-59 * * * long_running_job2
+// 0-59 * * * * job1
+// 0-59 * * * * long_running_job2
 //User edits crontab to:
-// 0-59 * * * job1_updated
-// 0-59 * * * long_running_job2
+// 0-59 * * * * job1_updated
+// 0-59 * * * * long_running_job2
 //Bug: crond can now start another long_running_job2 even if old one
 //is still running.
+//OTOH most other versions of cron do not wait for job termination anyway,
+//they end up with multiple copies of jobs if they don't terminate soon enough.
 static void delete_cronfile(const char *userName)
 {
 	CronFile **pfile = &G.cron_files;
-- 
1.7.1



More information about the busybox-cvs mailing list