[git commit master] builtin_read: note about better implementation
Denys Vlasenko
vda.linux at googlemail.com
Wed Jan 13 13:53:49 UTC 2010
commit: http://git.busybox.net/busybox/commit/?id=03d81ef43aca1808255d1a2a19ec394ed805eee8
branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master
Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
shell/builtin_read.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/shell/builtin_read.c b/shell/builtin_read.c
index 412bcf8..73b0949 100644
--- a/shell/builtin_read.c
+++ b/shell/builtin_read.c
@@ -20,6 +20,11 @@
#include "shell_common.h"
#include "builtin_read.h"
+//TODO: use more efficient setvar() which takes a pointer to malloced "VAR=VAL"
+//string. hush naturally has it, and ash has setvareq().
+//Here we can simply store "VAR=" at buffer start and store read data directly
+//after "=", then pass buffer to setvar() to consume.
+
const char* FAST_FUNC
shell_builtin_read(void FAST_FUNC (*setvar)(const char *name, const char *val),
char **argv,
--
1.6.3.3
More information about the busybox-cvs
mailing list