[git commit] hush: optimize type builtin a bit more

Denys Vlasenko vda.linux at googlemail.com
Thu May 28 07:58:43 UTC 2009


commit: http://git.busybox.net/busybox/commit/?id=5d7cca209085b31cc53df443d9439a0684646a77
branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master


Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 shell/hush.c |   11 +++++------
 1 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/shell/hush.c b/shell/hush.c
index 5000910..cda1c2e 100644
--- a/shell/hush.c
+++ b/shell/hush.c
@@ -6785,15 +6785,14 @@ static int builtin_type(char **argv)
 			type = "a shell builtin";
 		else if ((path = find_in_path(*argv)) != NULL)
 			type = path;
-
-		if (!type) {
+		else {
 			bb_error_msg("type: %s: not found", *argv);
 			ret = EXIT_FAILURE;
-		} else
-			printf("%s is %s\n", *argv, type);
+			continue;
+		}
 
-		if (path)
-			free(path);
+		printf("%s is %s\n", *argv, type);
+		free(path);
 	}
 
 	return ret;
-- 
1.6.0.6


More information about the busybox-cvs mailing list