[BusyBox 0004114]: comm bug on text files not ending in newline

bugs at busybox.net bugs at busybox.net
Wed Jul 16 23:18:16 UTC 2008


The following issue has been CLOSED 
====================================================================== 
http://busybox.net/bugs/view.php?id=4114 
====================================================================== 
Reported By:                cristic
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   4114
Category:                   Standards Compliance
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Resolution:                 open
Fixed in Version:           
====================================================================== 
Date Submitted:             07-14-2008 19:28 PDT
Last Modified:              07-16-2008 16:18 PDT
====================================================================== 
Summary:                    comm bug on text files not ending in newline
Description: 
Hello, comm (busybox-1.11.1) has a bug in the way in handles text files
that don't end in a newline.  It reports no differences, even when the
last lines are different.  Here is a small test case:

$ echo -n abc >A
$ echo -n def >B
$ ./comm A B
$

Here is what comm in GNU CoreUtils 6.12 prints:
$ ~/coreutils-6.12/src/comm A B
abc
        def
$

Best,
Cristian

====================================================================== 

---------------------------------------------------------------------- 
 vda - 07-14-08 23:45  
---------------------------------------------------------------------- 
Oh my. The code is awful.

Please try attached 9.patch. 

---------------------------------------------------------------------- 
 cristic - 07-16-08 14:12  
---------------------------------------------------------------------- 
Looks fine.  Thanks for the patch. 

---------------------------------------------------------------------- 
 vda - 07-16-08 16:18  
---------------------------------------------------------------------- 
fixed in svn 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-14-08 19:28  cristic        New Issue                                    
07-14-08 19:28  cristic        Status                   new => assigned     
07-14-08 19:28  cristic        Assigned To               => BusyBox         
07-14-08 23:45  vda            File Added: 9.patch                          
07-14-08 23:45  vda            Note Added: 0009324                          
07-15-08 18:07  cristic        Issue Monitored: cristic                     
07-16-08 14:12  cristic        Note Added: 0009424                          
07-16-08 16:18  vda            Status                   assigned => closed  
07-16-08 16:18  vda            Note Added: 0009474                          
======================================================================




More information about the busybox-cvs mailing list