svn commit: trunk/busybox: libbb util-linux

vda at busybox.net vda at busybox.net
Mon Jan 28 22:57:11 UTC 2008


Author: vda
Date: 2008-01-28 14:57:10 -0800 (Mon, 28 Jan 2008)
New Revision: 20917

Log:
*: move getopt reset code to better place(s)



Modified:
   trunk/busybox/libbb/appletlib.c
   trunk/busybox/libbb/getopt32.c
   trunk/busybox/libbb/vfork_daemon_rexec.c
   trunk/busybox/util-linux/getopt.c


Changeset:
Modified: trunk/busybox/libbb/appletlib.c
===================================================================
--- trunk/busybox/libbb/appletlib.c	2008-01-28 22:47:03 UTC (rev 20916)
+++ trunk/busybox/libbb/appletlib.c	2008-01-28 22:57:10 UTC (rev 20917)
@@ -638,7 +638,6 @@
 		argc++;
 
 	/* Reinit some shared global data */
-	optind = 1;
 	xfunc_error_retval = EXIT_FAILURE;
 
 	applet_name = APPLET_NAME(applet_no);

Modified: trunk/busybox/libbb/getopt32.c
===================================================================
--- trunk/busybox/libbb/getopt32.c	2008-01-28 22:47:03 UTC (rev 20916)
+++ trunk/busybox/libbb/getopt32.c	2008-01-28 22:57:10 UTC (rev 20917)
@@ -473,11 +473,30 @@
 		}
 	}
 
-	/* In case getopt32 was already called, reinit some state */
+	/* In case getopt32 was already called:
+	 * reset the libc getopt() function, which keeps internal state.
+	 *
+	 * BSD-derived getopt() functions require that optind be set to 1 in
+	 * order to reset getopt() state.  This used to be generally accepted
+	 * way of resetting getopt().  However, glibc's getopt()
+	 * has additional getopt() state beyond optind, and requires that
+	 * optind be set to zero to reset its state.  So the unfortunate state of
+	 * affairs is that BSD-derived versions of getopt() misbehave if
+	 * optind is set to 0 in order to reset getopt(), and glibc's getopt()
+	 * will core dump if optind is set 1 in order to reset getopt().
+	 * 
+	 * More modern versions of BSD require that optreset be set to 1 in
+	 * order to reset getopt().   Sigh.  Standards, anyone?
+	 */
+#ifdef __GLIBC__
+	optind = 0;
+#else /* BSD style */
 	optind = 1;
-	/* optarg = NULL; opterr = 0; optopt = 0; ?? */
+	/* optreset = 1; */
+#endif
+	/* optarg = NULL; opterr = 0; optopt = 0; - do we need this?? */
 
-	/* Note: just "getopt() <= 0" will not work good for
+	/* Note: just "getopt() <= 0" will not work well for
 	 * "fake" short options, like this one:
 	 * wget $'-\203' "Test: test" http://kernel.org/
 	 * (supposed to act as --header, but doesn't) */
@@ -487,7 +506,7 @@
 #else
 	while ((c = getopt(argc, argv, applet_opts)) != -1) {
 #endif
-		c &= 0xff; /* fight libc's sign extends */
+		c &= 0xff; /* fight libc's sign extension */
  loop_arg_is_opt:
 		for (on_off = complementary; on_off->opt != c; on_off++) {
 			/* c==0 if long opt have non NULL flag */

Modified: trunk/busybox/libbb/vfork_daemon_rexec.c
===================================================================
--- trunk/busybox/libbb/vfork_daemon_rexec.c	2008-01-28 22:47:03 UTC (rev 20916)
+++ trunk/busybox/libbb/vfork_daemon_rexec.c	2008-01-28 22:57:10 UTC (rev 20917)
@@ -137,26 +137,6 @@
 	 * die_sleep and longjmp here instead. */
 	die_sleep = -1;
 
-	/* Reset the libc getopt() function, which keeps internal state.
-	 *
-	 * BSD-derived getopt() functions require that optind be reset to 1 in
-	 * order to reset getopt() state.  This used to be generally accepted
-	 * way of resetting getopt().  However, glibc's getopt()
-	 * has additional getopt() state beyond optind, and requires that
-	 * optind be set zero to reset its state.  So the unfortunate state of
-	 * affairs is that BSD-derived versions of getopt() misbehave if
-	 * optind is set to 0 in order to reset getopt(), and glibc's getopt()
-	 * will core ump if optind is set 1 in order to reset getopt().
-	 * 
-	 * More modern versions of BSD require that optreset be set to 1 in
-	 * order to reset getopt().   Sigh.  Standards, anyone?
-	 */
-#ifdef __GLIBC__
-	optind = 0;
-#else /* BSD style */
-	optind = 1;
-	/* optreset = 1; */
-#endif
 	/* option_mask32 = 0; - not needed */
 
 	argc = 1;

Modified: trunk/busybox/util-linux/getopt.c
===================================================================
--- trunk/busybox/util-linux/getopt.c	2008-01-28 22:47:03 UTC (rev 20916)
+++ trunk/busybox/util-linux/getopt.c	2008-01-28 22:57:10 UTC (rev 20917)
@@ -155,8 +155,15 @@
 
 	if (quiet_errors) /* No error reporting from getopt(3) */
 		opterr = 0;
-	optind = 0; /* Reset getopt(3) */
 
+	/* Reset getopt(3) (see libbb/getopt32.c for long rant) */
+#ifdef __GLIBC__
+        optind = 0;
+#else /* BSD style */
+        optind = 1;
+        /* optreset = 1; */
+#endif
+
 	while (1) {
 		opt =
 #if ENABLE_GETOPT_LONG




More information about the busybox-cvs mailing list