[BusyBox 0001143]: [patch] support for mount LABEL=xxx and
bugs at busybox.net
bugs at busybox.net
Mon Feb 18 21:09:09 UTC 2008
The following issue has been CLOSED
======================================================================
http://busybox.net/bugs/view.php?id=1143
======================================================================
Reported By: eburghar
Assigned To: BusyBox
======================================================================
Project: BusyBox
Issue ID: 1143
Category: Documentation
Reproducibility: always
Severity: feature
Priority: normal
Status: closed
Resolution: open
Fixed in Version:
======================================================================
Date Submitted: 01-05-2007 01:42 PST
Last Modified: 02-18-2008 13:09 PST
======================================================================
Summary: [patch] support for mount LABEL=xxx and
Description:
This a backport from nash to support a LABEL=xxx option to mount filesystem
without knowing in which device it is located (boot from a usb key for
example).
The list of filesystems and raid recognized is pretty long but all is
enterely configurable in the spirit of busybox.
Regards
======================================================================
----------------------------------------------------------------------
jkolb - 03-22-07 10:46
----------------------------------------------------------------------
Patch updated to apply against 1.4.1
----------------------------------------------------------------------
vda - 02-18-08 12:11
----------------------------------------------------------------------
uuidcache_init_partitions(void)
{
static char ptname[100]; <=== no way you can have such static in
bbox
...
+char * get_spec_by_uuid(const char *uuid, int * major, int * minor);
+char * get_spec_by_volume_label(const char *volumelabel, int * major, int
* minor);
+int display_uuid_cache(void);
These functions are unused.
util-linux/volume_id/*.h - why do you need one *.h file per declaration?
Feel masochistic today?
+ procpt = fopen(PROC_PARTITIONS, "r");
+ if (!procpt) {
+ static int warn = 0;
+ if (!warn++)
+ fprintf (stderr, _("mount: could not open %s, so UUID
and LABEL "
+ "conversion cannot be done.\n"),
+ PROC_PARTITIONS);
+ return;
+ }
Good Lord. Just use xfopen. If /proc/partitions won't open, something is
teeribly wrong anyway, what's the point in trying to continue?
+ static unsigned int sectors[] = {
+ 63, 255, 256, 16, 399, 0
+ };
"const" is missing.
+struct hfs_mdb {
...
+} __attribute__((__packed__)) *hfs;
Please. Do not use global variables unless you have to.
+ printf("-");
bb_putchar?
+ strcpy(id->type_version, "1");
Can you store two bytes without function call?
Not needed: util-linux/volume_id/Makefile
And so on and so forth...
----------------------------------------------------------------------
vda - 02-18-08 13:09
----------------------------------------------------------------------
Applied with name, many fixes in rev. 21054.
Issue History
Date Modified Username Field Change
======================================================================
01-05-07 01:42 eburghar New Issue
01-05-07 01:42 eburghar Status new => assigned
01-05-07 01:42 eburghar Assigned To => BusyBox
01-05-07 01:42 eburghar File Added: busybox-1.2.2-mountlabel.patch
01-05-07 01:43 eburghar Issue Monitored: eburghar
03-22-07 10:46 jkolb File Added: busybox-1.4.1-mountlabel.patch
03-22-07 10:46 jkolb Note Added: 0002270
02-18-08 12:11 vda Note Added: 0005074
02-18-08 12:59 vda File Added: 5.patch
02-18-08 13:09 vda Status assigned => closed
02-18-08 13:09 vda Note Added: 0005084
======================================================================
More information about the busybox-cvs
mailing list