[BusyBox 0002094]: Use ptsname_r instead of ptsname in telnetd.c

[bugs at busybox.net]

The following issue has been CLOSED 
====================================================================== 
http://busybox.net/bugs/view.php?id=2094 
====================================================================== 
Reported By:                jac_goudsmit
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   2094
Category:                   Networking Support
Reproducibility:            sometimes
Severity:                   minor
Priority:                   normal
Status:                     closed
Resolution:                 won't fix
Fixed in Version:           
====================================================================== 
Date Submitted:             02-08-2008 13:42 PST
Last Modified:              02-08-2008 17:45 PST
====================================================================== 
Summary:                    Use ptsname_r instead of ptsname in telnetd.c
Description: 
The Busybox telnet daemon (networking/telnetd.c) uses ptsname(3) to find
the slave device of a terminal. However apparently at least in some
environments this function fails consistently: it always returns NULL.

The ptsname_r(3) function is a replacement for ptsname() that doesn't
require thread-local storage and is likely to work in more environments,
so I propose that the code be changed to use ptsname_r instead of
ptsname/strcpy or equivalent.
====================================================================== 

---------------------------------------------------------------------- 
 vapier - 02-08-08 17:45  
---------------------------------------------------------------------- 
if ptsname() is returning NULL on your system, something is broken and you
should fix that.  ptsname_r() is not portable nor is it desirable to use
in place of ptsname().  busybox is not a multithreaded application thus
there is no need to use reentrant versions of any function. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
02-08-08 13:42  jac_goudsmit   New Issue                                    
02-08-08 13:42  jac_goudsmit   Status                   new => assigned     
02-08-08 13:42  jac_goudsmit   Assigned To               => BusyBox         
02-08-08 17:45  vapier         Note Added: 0003754                          
02-08-08 17:45  vapier         Status                   assigned => closed  
02-08-08 17:45  vapier         Resolution               open => won't fix   
======================================================================