[BusyBox 0004734]: mdev doesn't work as firmware loader, patch attached

[bugs at busybox.net]

A NOTE has been added to this issue. 
====================================================================== 
http://busybox.net/bugs/view.php?id=4734 
====================================================================== 
Reported By:                hughdavenport
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   4734
Category:                   Kernel Module Support
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
====================================================================== 
Date Submitted:             08-26-2008 01:45 PDT
Last Modified:              08-29-2008 01:43 PDT
====================================================================== 
Summary:                    mdev doesn't work as firmware loader, patch attached
Description: 
using mdev as firmware loader didn't work for me so I investigated the
code
fix was simple, close to end of mdev.c if had 
if (ENABLE...LOAD_FIRMWARE) {
...
}
I just changed it to use a preprocessor #if. this has fixed it, patch is
supplied

====================================================================== 

---------------------------------------------------------------------- 
 vda - 08-29-08 01:23  
---------------------------------------------------------------------- 
I do not understand.

-                       if (ENABLE_FEATURE_MDEV_LOAD_FIRMWARE) {
+#if ENABLE_FEATURE_MDEV_LOAD_FIRMWARE

So, it was not entering the if() even though
ENABLE_FEATURE_MDEV_LOAD_FIRMWARE == 1? Wow. 

---------------------------------------------------------------------- 
 hughdavenport - 08-29-08 01:43  
---------------------------------------------------------------------- 
yeh thats what i though. patch seemed to fix it, but whats stranger is that
it now works without the patch. oh well, i guess this issue can be dropped.
must of been something else to do with my system that has since been fixed.
cheers 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
08-26-08 01:45  hughdavenport  New Issue                                    
08-26-08 01:45  hughdavenport  Status                   new => assigned     
08-26-08 01:45  hughdavenport  Assigned To               => BusyBox         
08-26-08 01:45  hughdavenport  File Added: busybox-1.12.0.patch                 
  
08-29-08 01:23  vda            Note Added: 0010874                          
08-29-08 01:43  hughdavenport  Note Added: 0010894                          
======================================================================