svn commit: trunk/busybox/testsuite

vda at busybox.net vda at busybox.net
Sat Apr 26 10:14:26 UTC 2008


Author: vda
Date: 2008-04-26 03:14:25 -0700 (Sat, 26 Apr 2008)
New Revision: 21873

Log:
runtest: use numeric compare instead of string where appropriate



Modified:
   trunk/busybox/testsuite/runtest


Changeset:
Modified: trunk/busybox/testsuite/runtest
===================================================================
--- trunk/busybox/testsuite/runtest	2008-04-25 23:20:25 UTC (rev 21872)
+++ trunk/busybox/testsuite/runtest	2008-04-26 10:14:25 UTC (rev 21873)
@@ -37,7 +37,7 @@
 #	echo "Running testcase $testcase"
 	d="$tsdir" sh -x -e "$testcase" >"$testname.stdout.txt" 2>&1
 	status=$?
-	if [ $status != 0 ]; then
+	if [ $status -ne 0 ]; then
 		echo "FAIL: $testname"
 		if [ x"$VERBOSE" != x ]; then
 			cat "$testname.stdout.txt"
@@ -71,7 +71,7 @@
 			continue
 		fi
 		run_applet_testcase "$applet" "$testcase"
-		test $? = 0 || status=1
+		test $? -eq 0 || status=1
 	done
 	return $status
 }
@@ -125,7 +125,7 @@
 	# Any old-style tests for this applet?
 	if [ "$applet" != "CVS" -a -d "$tsdir/$applet" ]; then
 		run_applet_tests "$applet"
-		test $? = 0 || status=1
+		test $? -eq 0 || status=1
 	fi
 
 	# Is this a new-style test?
@@ -139,14 +139,14 @@
 		fi
 #		echo "Running test ${tsdir:-.}/${applet}.tests"
 		PATH="$LINKSDIR:$tsdir:$bindir:$PATH" "${tsdir:-.}/${applet}.tests"
-		test $? = 0 || status=1
+		test $? -eq 0 || status=1
 	fi
 done
 
 # Leaving the dir makes it somewhat easier to run failed test by hand
 #rm -rf "$LINKSDIR"
 
-if [ $status != 0 -a x"$VERBOSE" = x ]; then
+if [ $status -ne 0 -a x"$VERBOSE" = x ]; then
 	echo "Failures detected, running with -v (verbose) will give more info"
 fi
 exit $status




More information about the busybox-cvs mailing list