[BusyBox 0001343]: arp ethers support

bugs at busybox.net bugs at busybox.net
Sun May 20 17:35:13 UTC 2007


A NOTE has been added to this issue. 
====================================================================== 
http://busybox.net/bugs/view.php?id=1343 
====================================================================== 
Reported By:                ralf
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   1343
Category:                   Networking Support
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     assigned
====================================================================== 
Date Submitted:             05-11-2007 07:22 PDT
Last Modified:              05-20-2007 10:35 PDT
====================================================================== 
Summary:                    arp ethers support
Description: 
With this patch arp can read addresses from a static file
====================================================================== 

---------------------------------------------------------------------- 
 vda - 05-20-07 06:29  
---------------------------------------------------------------------- 
Indeed, "standard" arp has this option. However, I can't apply this patch
as-is:

1. -f option is not made conditional (it should be, because this
functionality is not essential for every user).

2. If I understand it right, /etc/ethers looks like:
00:00:4b:3e:45:e2 192.168.1.1
00:00:56:3e:36:1f 192.168.1.2
Your parsing code seems to be too complex for such a simple file format.
If you handle more complex format, please document example(s) in source
code comments.

3. arp_file() body is whitespace damaged; and please avoid assignments in
ifs like 'if ((fp = fopen(name, "r"))' 

---------------------------------------------------------------------- 
 ralf - 05-20-07 10:35  
---------------------------------------------------------------------- 
vda: i was using an older busybox, now i have the current svn patch

1. True, even if the amount of code is so little...
2. yes, the syntax is like: 00:00:4b:3e:45:e2 192.168.1.1 but wh have to
handle "" and \ as the ip could be an hostname. btw, the code was taken
from standard net-tools
3: fixed 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
05-11-07 07:22  ralf           New Issue                                    
05-11-07 07:22  ralf           Status                   new => assigned     
05-11-07 07:22  ralf           Assigned To               => BusyBox         
05-11-07 07:22  ralf           File Added: ethers.diff                      
05-11-07 07:26  ralf           Issue Monitored: ralf                        
05-20-07 06:29  vda            Note Added: 0002384                          
05-20-07 10:35  ralf           Note Added: 0002386                          
======================================================================




More information about the busybox-cvs mailing list