[BusyBox 0001245]: tftp client doesn't work

[bugs at busybox.net]

The following issue has been CLOSED 
====================================================================== 
http://busybox.net/bugs/view.php?id=1245 
====================================================================== 
Reported By:                dibacco73
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   1245
Category:                   Documentation
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Resolution:                 open
Fixed in Version:           
====================================================================== 
Date Submitted:             03-02-2007 00:36 PST
Last Modified:              03-02-2007 15:08 PST
====================================================================== 
Summary:                    tftp client doesn't work
Description: 
I have an embedded system with busybox-1.4.0, connected in a LAN where
there is an tftp server (tftp32). I can ping the tftp server but when I
try to do an tftp session using the tftp client embedded in busybox I
receive a timeout.
====================================================================== 

---------------------------------------------------------------------- 
 razzor - 03-02-07 04:47  
---------------------------------------------------------------------- 
At least tftp-hpa ( http://www.kernel.org/pub/software/network/tftp/ )
replies from a different port than udp/69.
So these checks in networking/tftp.c (1.4.1) are invalid:

if (from->sa_family == AF_INET6)
	if (((struct sockaddr_in6*)from)->sin6_port != port)
		goto recv_again;

if (from->sa_family == AF_INET)
	if (((struct sockaddr_in*)from)->sin_port != port)
		goto recv_again;

 

---------------------------------------------------------------------- 
 dibacco73 - 03-02-07 07:13  
---------------------------------------------------------------------- 
Removing the checks in tftp.c leads to another problem:

tftp32 server says:
error 10054 in system call recv. An existing connection was forcibly
closed by the remote host 

The remote host is the embedded busybox system doing running tftp client. 

---------------------------------------------------------------------- 
 vda - 03-02-07 15:08  
---------------------------------------------------------------------- 
Already fixed in svn.

Also adding patch to post 1.4.1:

http://busybox.net/downloads/fixes-1.4.1/busybox-1.4.1-tftp.patch 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
03-02-07 00:36  dibacco73      New Issue                                    
03-02-07 00:36  dibacco73      Status                   new => assigned     
03-02-07 00:36  dibacco73      Assigned To               => BusyBox         
03-02-07 04:46  razzor         Note Added: 0002194                          
03-02-07 04:47  razzor         Note Edited: 0002194                         
03-02-07 07:13  dibacco73      Note Added: 0002195                          
03-02-07 15:08  vda            Status                   assigned => closed  
03-02-07 15:08  vda            Note Added: 0002197                          
======================================================================