[BusyBox 0001438]: [patch] fix assumptions the build environment is Linux

bugs at busybox.net bugs at busybox.net
Sat Jul 21 16:09:44 UTC 2007


A NOTE has been added to this issue. 
====================================================================== 
http://busybox.net/bugs/view.php?id=1438 
====================================================================== 
Reported By:                mirabilos
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   1438
Category:                   Standards Compliance
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
====================================================================== 
Date Submitted:             07-20-2007 05:41 PDT
Last Modified:              07-21-2007 09:09 PDT
====================================================================== 
Summary:                    [patch] fix assumptions the build environment is
Linux
Description: 
• not all systems have /bin/bash

• compressed usage generation does not work if the target sy-
  stem deviates from the build system too much: busybox itself
  includes several Linux headers, which obviously aren't existent
  on a real UNIX® system from which buxybox is cross-compiled;
  disabling compressed usage was not enough, since the utility
  programme was still built (I'd be glad if you have a better
  fix, since like this you still have to define a variable)

====================================================================== 

---------------------------------------------------------------------- 
 vapier - 07-20-07 15:37  
---------------------------------------------------------------------- 
no, not all systems have /bin/bash, but trylink is a POSIX shell script and
all systems must have a /bin/sh

as for usage, it builds fine for me on OS X so i dont know what your
trouble is, but simply disabling it in the Makefile is incorrect 

---------------------------------------------------------------------- 
 vda - 07-21-07 07:39  
---------------------------------------------------------------------- 
-#!/bin/sh
+#!/usr/bin/env bash

Can you fix bash-isms in trylink instead, so that it runs under your
shell. Which one do you use?

>compressed usage generation does not work

Then proprly #ifdef out relevant pieces conditionally on
FEATURE_COMPRESS_USAGE. (We are a bit lax with it now, yes.) Your patch is
a quick hack 

---------------------------------------------------------------------- 
 mirabilos - 07-21-07 09:09  
---------------------------------------------------------------------- 
I'll see to the bashisms - when looking now, I don't see
them either. Maybe the script changed in the meantime, I
think that part was first done for 1.2.x or so.

Regarding the "compressed help" stuff: even if disabling
the "compressed help" option, it still tries to build a
host programme (helper) which breaks on BSD (but I will
try again without that diff if you think it shouldn't). 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-20-07 05:41  mirabilos      New Issue                                    
07-20-07 05:41  mirabilos      Status                   new => assigned     
07-20-07 05:41  mirabilos      Assigned To               => BusyBox         
07-20-07 05:41  mirabilos      File Added: 950-unportability.patch              
     
07-20-07 15:37  vapier         Note Added: 0002610                          
07-21-07 07:39  vda            Note Added: 0002615                          
07-21-07 09:09  mirabilos      Note Added: 0002622                          
======================================================================




More information about the busybox-cvs mailing list