svn commit: trunk/busybox/init

[Denys Vlasenko]

On Tuesday 25 December 2007 04:30, vapier at busybox.net wrote:
> Author: vapier
> Date: 2007-12-24 20:30:14 -0800 (Mon, 24 Dec 2007)
> New Revision: 20683
>
> Log:
> convert #if to if -- let gcc optimize away dead code for us

Thanks.

I worry that sometimes gcc is too dumb.
#if/#endif is dead sure method to disable something,
hoping for compiler/linker to be smart is less reliable.

Although I agree that #ifdef forest tend to clutter up things
(for example, dreaded httpd.c), and I'd like such cases to be
cleaned up.

Bit in these cases:

#ifdef BUT_RUN_ACTIONS_ALREADY_DOES_WAITING
# define BRAADS 1
#else
# define BRAADS 0
#endif

replacing two #directives with five doesn't seem to be an improvement
in readability.
--
vda