svn commit: trunk/busybox/libbb

vda at busybox.net vda at busybox.net
Sun Dec 2 07:18:32 UTC 2007


Author: vda
Date: 2007-12-01 23:18:29 -0800 (Sat, 01 Dec 2007)
New Revision: 20605

Log:
explain why we use mmap instead of malloc



Modified:
   trunk/busybox/libbb/copyfd.c


Changeset:
Modified: trunk/busybox/libbb/copyfd.c
===================================================================
--- trunk/busybox/libbb/copyfd.c	2007-12-02 06:30:57 UTC (rev 20604)
+++ trunk/busybox/libbb/copyfd.c	2007-12-02 07:18:29 UTC (rev 20605)
@@ -22,6 +22,8 @@
 	char *buffer;
 	int buffer_size;
 
+	/* We want page-aligned buffer, just in case kernel is clever
+	 * and can do page-aligned io more efficiently */
 	buffer = mmap(NULL, CONFIG_FEATURE_COPYBUF_KB * 1024,
 			PROT_READ | PROT_WRITE,
 			MAP_PRIVATE | MAP_ANON,




More information about the busybox-cvs mailing list