svn commit: trunk/busybox: networking

vda at busybox.net vda at busybox.net
Wed Apr 18 21:14:47 UTC 2007


Author: vda
Date: 2007-04-18 14:14:46 -0700 (Wed, 18 Apr 2007)
New Revision: 18492

Log:
"Unify base64 handling" is done, remove TODO


Modified:
   trunk/busybox/TODO
   trunk/busybox/networking/httpd.c


Changeset:
Modified: trunk/busybox/TODO
===================================================================
--- trunk/busybox/TODO	2007-04-18 21:00:21 UTC (rev 18491)
+++ trunk/busybox/TODO	2007-04-18 21:14:46 UTC (rev 18492)
@@ -36,12 +36,7 @@
     modutils. The orig depmod is rather pointless to have to add to a firmware image
     in when we already have a insmod/rmmod and friends.
   Unify base64 handling.
-    There's base64 encoding and decoding going on in:
-      networking/wget.c:base64enc()
-      coreutils/uudecode.c:read_base64()
-      coreutils/uuencode.c:tbl_base64[]
-      networking/httpd.c:decodeBase64()
-    And probably elsewhere.  That needs to be unified into libbb functions.
+    [done]
   Do a SUSv3 audit
     Look at the full Single Unix Specification version 3 (available online at
     "http://www.opengroup.org/onlinepubs/009695399/nfindex.html") and

Modified: trunk/busybox/networking/httpd.c
===================================================================
--- trunk/busybox/networking/httpd.c	2007-04-18 21:00:21 UTC (rev 18491)
+++ trunk/busybox/networking/httpd.c	2007-04-18 21:14:46 UTC (rev 18492)
@@ -765,10 +765,9 @@
  ****************************************************************************/
 static void decodeBase64(char *Data)
 {
-
 	const unsigned char *in = (const unsigned char *)Data;
 	// The decoded size will be at most 3/4 the size of the encoded
-	unsigned long ch = 0;
+	unsigned ch = 0;
 	int i = 0;
 
 	while (*in) {
@@ -798,7 +797,7 @@
 			i = 0;
 		}
 	}
-	*Data = 0;
+	*Data = '\0';
 }
 #endif
 




More information about the busybox-cvs mailing list