svn commit: trunk/busybox/coreutils

aldot at busybox.net aldot at busybox.net
Thu Sep 21 20:40:57 UTC 2006


Author: aldot
Date: 2006-09-21 13:40:56 -0700 (Thu, 21 Sep 2006)
New Revision: 16172

Log:
- silence gcc warning about a funcptr possibly being used uninitialized.
  This is a perfect example on where we should NOT care if the functor is not
  initialized since the result will not be what the user may expect.
  Safe bet would be to init to NULL, but let's try normal uu for good measure.
- fix commentary typo while at it.


Modified:
   trunk/busybox/coreutils/uudecode.c


Changeset:
Modified: trunk/busybox/coreutils/uudecode.c
===================================================================
--- trunk/busybox/coreutils/uudecode.c	2006-09-21 12:30:16 UTC (rev 16171)
+++ trunk/busybox/coreutils/uudecode.c	2006-09-21 20:40:56 UTC (rev 16172)
@@ -36,7 +36,7 @@
 		}
 
 		line_ptr++;
-		/* Tolerate an overly long line to acomadate a possible exta '`' */
+		/* Tolerate an overly long line to accomodate a possible exta '`' */
 		if (strlen(line_ptr) < (size_t)length) {
 			bb_error_msg_and_die("Short file");
 		}
@@ -125,7 +125,7 @@
 
 int uudecode_main(int argc, char **argv)
 {
-	int (*decode_fn_ptr) (FILE * src, FILE * dst);
+	int (*decode_fn_ptr)(FILE * src, FILE * dst) = read_stduu; /* silence gcc */
 	FILE *src_stream;
 	char *outname = NULL;
 	char *line;




More information about the busybox-cvs mailing list