[BusyBox 0001038]: "cmp" can't use options
bugs at busybox.net
bugs at busybox.net
Wed Sep 20 15:30:10 UTC 2006
The following issue has been CLOSED
======================================================================
http://busybox.net/bugs/view.php?id=1038
======================================================================
Reported By: rockeychu
Assigned To: BusyBox
======================================================================
Project: BusyBox
Issue ID: 1038
Category: Other
Reproducibility: always
Severity: major
Priority: normal
Status: closed
Resolution: open
Fixed in Version:
======================================================================
Date Submitted: 09-20-2006 01:24 PDT
Last Modified: 09-20-2006 08:30 PDT
======================================================================
Summary: "cmp" can't use options
Description:
patch as following:
--- busybox_org/coreutils/cmp.c 2006-09-04 17:55:30.000000000 +0800
+++ busybox/coreutils/cmp.c 2006-09-20 16:08:46.282088000 +0800
@@ -56,7 +56,7 @@
opt = bb_getopt_ulflags(argc, argv, opt_chars);
- if ((opt & (CMP_OPT_s|CMP_OPT_l))
+ if (((opt & (CMP_OPT_s|CMP_OPT_l)) == 3)
|| (((unsigned int)(--argc - optind)) > 1))
bb_show_usage();
@@ -103,7 +103,7 @@
* make sure we fflush before writing to
stderr. */
xfflush_stdout();
}
- if (!opt & CMP_OPT_s) {
+ if (!(opt & CMP_OPT_s)) {
if (opt & CMP_OPT_l) {
line_pos = c1; /* line_pos is
unused in the -l case. */
}
======================================================================
----------------------------------------------------------------------
bernhardf - 09-20-06 08:30
----------------------------------------------------------------------
Fixed in r16162. Thanks for spotting this..
Issue History
Date Modified Username Field Change
======================================================================
09-20-06 01:24 rockeychu New Issue
09-20-06 01:24 rockeychu Status new => assigned
09-20-06 01:24 rockeychu Assigned To => BusyBox
09-20-06 08:30 bernhardf Status assigned => closed
09-20-06 08:30 bernhardf Note Added: 0001639
======================================================================
More information about the busybox-cvs
mailing list