svn commit: trunk/busybox/loginutils

vda at busybox.net vda at busybox.net
Sun Sep 3 17:11:34 UTC 2006


Author: vda
Date: 2006-09-03 10:11:34 -0700 (Sun, 03 Sep 2006)
New Revision: 16045

Log:
sulogin: fix bug: -tNNN didn't work



Modified:
   trunk/busybox/loginutils/sulogin.c


Changeset:
Modified: trunk/busybox/loginutils/sulogin.c
===================================================================
--- trunk/busybox/loginutils/sulogin.c	2006-09-03 16:33:58 UTC (rev 16044)
+++ trunk/busybox/loginutils/sulogin.c	2006-09-03 17:11:34 UTC (rev 16045)
@@ -52,7 +52,7 @@
 int sulogin_main(int argc, char **argv)
 {
 	char *cp;
-	char *device = (char *) 0;
+	char *device = NULL;
 	const char *name = "root";
 	int timeout = 0;
 
@@ -68,14 +68,15 @@
 	openlog("sulogin", LOG_PID | LOG_CONS | LOG_NOWAIT, LOG_AUTH);
 	if (argc > 1) {
 		if (strncmp(argv[1], "-t", 2) == 0) {
-			if (strcmp(argv[1], "-t") == 0) {
+			if (argv[1][2] == '\0') { /* -t NN */
 				if (argc > 2) {
 					timeout = atoi(argv[2]);
 					if (argc > 3) {
 						device = argv[3];
 					}
 				}
-			} else {
+			} else { /* -tNNN */
+				timeout = atoi(&argv[1][2]);
 				if (argc > 2) {
 					device = argv[2];
 				}
@@ -87,7 +88,7 @@
 			close(0);
 			close(1);
 			close(2);
-			if (open(device, O_RDWR) >= 0) {
+			if (open(device, O_RDWR) == 0) {
 				dup(0);
 				dup(0);
 			} else {




More information about the busybox-cvs mailing list