svn commit: trunk/busybox/networking

[vda at busybox.net]

Author: vda
Date: 2006-11-21 13:35:14 -0800 (Tue, 21 Nov 2006)
New Revision: 16615

Log:
httpd: comment on QUERY_STRING


Modified:
   trunk/busybox/networking/httpd.c


Changeset:
Modified: trunk/busybox/networking/httpd.c
===================================================================
--- trunk/busybox/networking/httpd.c	2006-11-21 21:23:21 UTC (rev 16614)
+++ trunk/busybox/networking/httpd.c	2006-11-21 21:35:14 UTC (rev 16615)
@@ -1039,9 +1039,13 @@
 		setenv1("SCRIPT_FILENAME", realpath_buff);
 		/* set SCRIPT_NAME as full path: /cgi-bin/dirs/script.cgi */
 		setenv1("SCRIPT_NAME", purl);
-		/* TODO: bug 996 says we need to decodeString(config->query)
-		 * before placing it into env. Is this true? Add example
-		 * in the comment please... */
+		/* http://hoohoo.ncsa.uiuc.edu/cgi/env.html:
+		 * QUERY_STRING: The information which follows the ? in the URL
+		 * which referenced this script. This is the query information.
+		 * It should not be decoded in any fashion. This variable
+		 * should always be set when there is query information,
+		 * regardless of command line decoding. */
+		/* (Older versions of bbox seemed to do some decoding) */
 		setenv1("QUERY_STRING", config->query);
 		setenv1("SERVER_SOFTWARE", httpdVersion);
 		putenv("SERVER_PROTOCOL=HTTP/1.0");