svn commit: trunk/busybox/coreutils

aldot at busybox.net aldot at busybox.net
Fri Nov 17 11:28:00 UTC 2006


Author: aldot
Date: 2006-11-17 03:28:00 -0800 (Fri, 17 Nov 2006)
New Revision: 16552

Log:
- end may be used uninitialized.
- TODO: should eventually use skip_whitespace there


Modified:
   trunk/busybox/coreutils/sort.c


Changeset:
Modified: trunk/busybox/coreutils/sort.c
===================================================================
--- trunk/busybox/coreutils/sort.c	2006-11-17 11:21:23 UTC (rev 16551)
+++ trunk/busybox/coreutils/sort.c	2006-11-17 11:28:00 UTC (rev 16552)
@@ -51,7 +51,7 @@
 
 static char *get_key(char *str, struct sort_key *key, int flags)
 {
-	int start=0,end,len,i,j;
+	int start = 0, end = 0, len, i, j;
 
 	/* Special case whole string, so we don't have to make a copy */
 	if(key->range[0]==1 && !key->range[1] && !key->range[2] && !key->range[3]
@@ -83,6 +83,7 @@
 	/* Key with explicit separator starts after separator */
 	if(key_separator && str[start]==key_separator) start++;
 	/* Strip leading whitespace if necessary */
+//XXX: skip_whitespace()
 	if(flags&FLAG_b) while(isspace(str[start])) start++;
 	/* Strip trailing whitespace if necessary */
 	if(flags&FLAG_bb) while(end>start && isspace(str[end-1])) end--;




More information about the busybox-cvs mailing list