[BusyBox 0000895]: Crond logs uninmportant messages.

[bugs at busybox.net]

The following issue has been REOPENED. 
====================================================================== 
http://busybox.net/bugs/view.php?id=895 
====================================================================== 
Reported By:                mootinator
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   895
Category:                   Documentation
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
====================================================================== 
Date Submitted:             06-03-2006 22:28 PDT
Last Modified:              06-29-2006 17:23 PDT
====================================================================== 
Summary:                    Crond logs uninmportant messages.
Description: 
In crond.c messages are logged:
if (level >= LogLevel)

LogLevel being the level configured by the user.  Since lower log levels
are more important, this comparison is backwards.  Because messages
currently get logged even with no  LogLevel specified (default is said to
be 8) I suspect there is a problem with the default level being set
incorrectly too.
====================================================================== 

---------------------------------------------------------------------- 
 landley - 06-29-06 10:07  
---------------------------------------------------------------------- 
What made you think a lower log level was less important?  I just grepped
through for the crondlog() calls and debug calls are 005, "ignoring" is
007, "process already running" is 011, inability to execute one of the
commands is 024, significant clock skew detected is 111, inability to
chdir to the crond database directory is 311...

Seems like a pretty straightforward progression to me... 

---------------------------------------------------------------------- 
 mootinator - 06-29-06 17:23  
---------------------------------------------------------------------- 
Myself and I suspect many other end users when they set a log level at
runtime are expecting to set the level based on the standard levels set
out in the definition for syslog where 0 is an emergency, and 7 is
LOG_INFO.

I can't even look at those values in the source and quickly determine
where I want to set the log level, since those numbers are being logically
& 0xf-ed before being compared to LogLevel (do you know what \311 & 0xf is
off the top of your head?)  It isn't a particularily useful implementation
at the very least. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-03-06 22:28  mootinator     New Issue                                    
06-03-06 22:28  mootinator     Status                   new => assigned     
06-03-06 22:28  mootinator     Assigned To               => BusyBox         
06-29-06 10:07  landley        Status                   assigned => closed  
06-29-06 10:07  landley        Note Added: 0001474                          
06-29-06 10:07  landley        Resolution               open => fixed       
06-29-06 17:23  mootinator     Status                   closed => feedback  
06-29-06 17:23  mootinator     Resolution               fixed => reopened   
06-29-06 17:23  mootinator     Note Added: 0001476                          
======================================================================