[BusyBox 0000901]: mount -a always reports failure of the last mount (but the mount is done)

bugs at busybox.net bugs at busybox.net
Mon Jun 12 16:10:50 UTC 2006


The following issue has been SUBMITTED. 
====================================================================== 
http://busybox.net/bugs/view.php?id=901 
====================================================================== 
Reported By:                iggarpe
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   901
Category:                   Other
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
====================================================================== 
Date Submitted:             06-12-2006 09:10 PDT
Last Modified:              06-12-2006 09:10 PDT
====================================================================== 
Summary:                    mount -a always reports failure of the last mount
(but the mount is done)
Description: 
The error management in mount.c is a bit twisty and definitely wrong in the
case of "-a". It will always report that the last mount failed (but it
didn't).

See the attached trivial patch. rc is set to zero unconditionally after
each successful fstab entry mount, since errors are reported as they
happen.

HOWEVER, this solution is also WRONG, since:

1- mount will return 0 (success) even if some auto entry in fstab cannot
be mounted.

2- mount will return 1 (error) if there are no auto entries in fstab.

As I said, error management here is just a bit too twisty for me, so I
think it's better if whoever wrote mount.c thinks a good way to handle the
two cases above.

====================================================================== 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-12-06 09:10  iggarpe        New Issue                                    
06-12-06 09:10  iggarpe        Status                   new => assigned     
06-12-06 09:10  iggarpe        Assigned To               => BusyBox         
06-12-06 09:10  iggarpe        File Added: mount.diff                       
======================================================================




More information about the busybox-cvs mailing list