svn commit: trunk/busybox
aldot at busybox.net
aldot at busybox.net
Sun Jun 4 16:05:04 UTC 2006
Author: aldot
Date: 2006-06-04 09:05:02 -0700 (Sun, 04 Jun 2006)
New Revision: 15281
Log:
- add note about removing superfluous fmt specifiers
Modified:
trunk/busybox/TODO
Changeset:
Modified: trunk/busybox/TODO
===================================================================
--- trunk/busybox/TODO 2006-06-04 15:37:59 UTC (rev 15280)
+++ trunk/busybox/TODO 2006-06-04 16:05:02 UTC (rev 15281)
@@ -259,12 +259,17 @@
if(!ioctl (fd, WDIOC_GETTIMEOUT, &tmo)) timer_duration = 1 + (tmo / 2);
Unfortunately, that needs linux/watchdog.h and that contains unfiltered
kernel types on some distros, which breaks the build.
-
+---
use bb_error_msg where appropriate: See
egrep "(printf.*\([[:space:]]*(stderr|2)|[^_]write.*\([[:space:]]*(stderr|2))"
-
+---
use bb_perror_msg where appropriate: See
egrep "[^_]perror"
+---
+ Remove superfluous fmt occurances: e.g.
+ fprintf(stderr, "%s: %s not found\n", "unalias", *argptr);
+ -> fprintf(stderr, "unalias: %s not found\n", *argptr);
+---
Code cleanup:
More information about the busybox-cvs
mailing list