[BusyBox 0000651]: mdev -s fails to work.

bugs at busybox.net bugs at busybox.net
Sun Jan 22 23:12:35 UTC 2006


A NOTE has been added to this issue. 
====================================================================== 
http://busybox.net/bugs/view.php?id=651 
====================================================================== 
Reported By:                Ken Milmore
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   651
Category:                   Other
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     assigned
====================================================================== 
Date Submitted:             01-20-2006 00:39 PST
Last Modified:              01-22-2006 15:12 PST
====================================================================== 
Summary:                    mdev -s fails to work.
Description: 
mdev -s fails consistently with error message of the form:
mknod /dev/hdc failed: Invalid argument
====================================================================== 

---------------------------------------------------------------------- 
 landley - 01-22-06 15:12  
---------------------------------------------------------------------- 
The newline thing we fixed in svn 13253, but your fix simplifies the code. 
The reason for the open coded ascii->int conversion is because this applet
is more than usually likely to be statically linked, and thus saving the
space taken up by the sscanf() library call is a bonus.  Then again, I'm a
really big fan of simplicity and this lets us save the loop, variable
initialization, and the null terminating step...

The missing ! on strcmp() floors me: I tested this and it worked.  (Really
I did.)  Did I check in the wrong version? 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
01-20-06 00:39  Ken Milmore    New Issue                                    
01-20-06 00:39  Ken Milmore    Status                   new => assigned     
01-20-06 00:39  Ken Milmore    Assigned To               => BusyBox         
01-20-06 00:39  Ken Milmore    File Added: mdev.c.patch                     
01-22-06 15:12  landley        Note Added: 0000974                          
======================================================================




More information about the busybox-cvs mailing list