[BusyBox 0000076]: Defined header CONFIG_FEATURE_DEVPTS from config.h doesn't take effect in telnetd.c

bugs at busybox.net bugs at busybox.net
Tue Jan 10 07:34:43 UTC 2006


The following issue has been CLOSED 
====================================================================== 
http://busybox.net/bugs/view.php?id=76 
====================================================================== 
Reported By:                vijaypadiyar
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   76
Category:                   Other
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     closed
Resolution:                 open
Fixed in Version:           
====================================================================== 
Date Submitted:             02-02-2005 03:13 PST
Last Modified:              01-09-2006 23:34 PST
====================================================================== 
Summary:                    Defined header CONFIG_FEATURE_DEVPTS from config.h
doesn't take effect in telnetd.c
Description: 
The following section of code in networking/telnetd.c doesn't get
implemented even if the header in question (CONFIG_FEATURE_DEVPTS) is
defined in config.h:

#ifdef CONFIG_FEATURE_DEVPTS
        p = open("/dev/ptmx", 2);
        if (p > 0) {
                grantpt(p);
                unlockpt(p);
                strcpy(line, ptsname(p));
                return(p);
        }
#else
...

To overcome this, I had to manually include the config.h file from
telnetd.c, by adding the following line to the file:

#include <config.h>
====================================================================== 

---------------------------------------------------------------------- 
 vodz - 09-19-05 05:07  
---------------------------------------------------------------------- 
No. Its old depend problem and released.
Please close this bug. 

---------------------------------------------------------------------- 
 landley - 01-09-06 23:34  
---------------------------------------------------------------------- 
Fixed a while back by #include "busybox.h" which sucks in config.h 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
02-02-05 03:13  vijaypadiyar   New Issue                                    
02-02-05 03:13  vijaypadiyar   File Added: telnetd.c                        
03-16-05 12:27  andersen       Assigned To              andersen => BusyBox 
09-19-05 05:07  vodz           Note Added: 0000555                          
01-09-06 23:34  landley        Status                   assigned => closed  
01-09-06 23:34  landley        Note Added: 0000910                          
======================================================================




More information about the busybox-cvs mailing list