[BusyBox 0000607]: mount -a will only correctly mount the first non noauto filesystem in /etc/fstab

[bugs at busybox.net]

The following issue has been CLOSED 
====================================================================== 
http://busybox.net/bugs/view.php?id=607 
====================================================================== 
Reported By:                iggarpe
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   607
Category:                   Other
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     closed
Resolution:                 open
Fixed in Version:           
====================================================================== 
Date Submitted:             12-19-2005 09:42 PST
Last Modified:              01-09-2006 21:31 PST
====================================================================== 
Summary:                    mount -a will only correctly mount the first non
noauto filesystem in /etc/fstab
Description: 
The title says it all. If in http://busybox.net/bugs/view.php?id=000606 the non
initialization of f for each
fstab entry iteration caused a crash, here, the non initialization of rc
causes premature exit.

See attached patch, which also fixes http://busybox.net/bugs/view.php?id=000606
in a better way.

Also, the if/else at the end of the fstab iteration loop is wrong, and if
not using mtab, will always run as if there had been an error. Fixed too
in the attached patch.

Also, the final error message is misplaced, because:

1- If cleanup is enabled, it will be using blockDevice, directory, etc
which have already been deallocated.

2- In the "all" case, will show the blockDevice, directory, etc values at
the end of the loop, which will not be right unless the error happened at
the very last line of /etc/fstab. Fixed in the attached patch.




====================================================================== 

---------------------------------------------------------------------- 
 landley - 01-09-06 21:11  
---------------------------------------------------------------------- 
I'm confused, the patch in 607 and the patch in 606 look the same to me. 
What "better way"?

If this patch fixes both, let me know.  (Mount -a still doesn't mix with
-o properly, and remount is still generally horked, but I'll fix that
eventually...) 

---------------------------------------------------------------------- 
 landley - 01-09-06 21:31  
---------------------------------------------------------------------- 
svn 13216 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
12-19-05 09:42  iggarpe        New Issue                                    
12-19-05 09:42  iggarpe        Status                   new => assigned     
12-19-05 09:42  iggarpe        Assigned To               => BusyBox         
12-19-05 09:42  iggarpe        File Added: mount.diff                       
01-09-06 21:11  landley        Note Added: 0000898                          
01-09-06 21:31  landley        Status                   assigned => closed  
01-09-06 21:31  landley        Note Added: 0000899                          
======================================================================