[BusyBox 0000742]: unterminated string in libbb/login.c

[bugs at busybox.net]

The following issue has been CLOSED 
====================================================================== 
http://busybox.net/bugs/view.php?id=742 
====================================================================== 
Reported By:                rfelker
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   742
Category:                   Security
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             02-19-2006 12:54 PST
Last Modified:              02-19-2006 15:03 PST
====================================================================== 
Summary:                    unterminated string in libbb/login.c
Description: 
In print_login_prompt, buf is not terminated if gethostname uses the full
buffer (the extra byte allocated for the terminating null is left
uninitialized).

(SuSv3 does not require NULL termination by gethostname in the case where
the full buffer is used.)

Also, HOST_NAME_MAX (portable, from limits.h) should be used instead of
MAXHOSTNAMELEN (nonportable, from sys/param.h).

====================================================================== 

---------------------------------------------------------------------- 
 vapier - 02-19-06 15:03  
---------------------------------------------------------------------- 
fixed in svn 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
02-19-06 12:54  rfelker        New Issue                                    
02-19-06 12:54  rfelker        Status                   new => assigned     
02-19-06 12:54  rfelker        Assigned To               => BusyBox         
02-19-06 15:03  vapier         Note Added: 0001119                          
02-19-06 15:03  vapier         Status                   assigned => closed  
02-19-06 15:03  vapier         Resolution               open => fixed       
======================================================================