[BusyBox 0000694]: the uuencode function is repeated in uuencode and wget.
bugs at busybox.net
bugs at busybox.net
Thu Feb 9 22:01:44 UTC 2006
A NOTE has been added to this issue.
======================================================================
http://busybox.net/bugs/view.php?id=694
======================================================================
Reported By: ehovland
Assigned To: BusyBox
======================================================================
Project: BusyBox
Issue ID: 694
Category: Other
Reproducibility: always
Severity: tweak
Priority: normal
Status: assigned
======================================================================
Date Submitted: 02-06-2006 13:13 PST
Last Modified: 02-09-2006 14:01 PST
======================================================================
Summary: the uuencode function is repeated in uuencode and
wget.
Description:
both coreutils/uuencode.c and networking/wget.c have a function to uuencode
data. It sure would be smart to have only one implementation and have both
uuencode and wget use it.
The attached patch moves the uuencode function to libbb/uuencode.c and
modifies coreutils/uuencode.c to use the libbb/uuencode.c version. It also
adds some encoding tests to testsuite/uuencode to make sure the move wasn't
stuffed up.
======================================================================
----------------------------------------------------------------------
ehovland - 02-06-06 13:27
----------------------------------------------------------------------
The second patch removes the base64enc function from networking/wget.c and
uses the libbb bb_uuencode with a base64 table.
I have not yet figured out how to test this for working in a way that can
be put into testsuite. So if anyone has any ideas, add a note.
----------------------------------------------------------------------
scott - 02-09-06 13:11
----------------------------------------------------------------------
Do we need depenency checks in the config for applets 'uuencode' and 'wget'
to be sure uuencode is enabled in the libbb? I know buildroot uses deps to
be sure required modules are selected.
Or is uuencode always compiled in libbb regardless of the applet config?
----------------------------------------------------------------------
ehovland - 02-09-06 14:01
----------------------------------------------------------------------
The patch as included always builds uuencode into libbb. I am willing to
rework the patch so that uuencode doesn't always get built in libbb and
then put in the checks in uuencode and wget applets.
Please advise.
Issue History
Date Modified Username Field Change
======================================================================
02-06-06 13:13 ehovland New Issue
02-06-06 13:13 ehovland Status new => assigned
02-06-06 13:13 ehovland Assigned To => BusyBox
02-06-06 13:13 ehovland File Added: move_uuencode_to_libbb.patch
02-06-06 13:25 ehovland File Added: remove_uuencode_from_wget.patch
02-06-06 13:27 ehovland Note Added: 0001051
02-09-06 13:11 scott Note Added: 0001072
02-09-06 14:01 ehovland Note Added: 0001073
======================================================================
More information about the busybox-cvs
mailing list