[BusyBox 0000679]: modprobe incrorrectly reads module parametrs from modules.conf

bugs at busybox.net bugs at busybox.net
Thu Feb 2 14:50:29 UTC 2006


The following issue has been CONFIRMED. 
====================================================================== 
http://busybox.net/bugs/view.php?id=679 
====================================================================== 
Reported By:                vicser
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   679
Category:                   Kernel Module Support
Reproducibility:            always
Severity:                   crash
Priority:                   normal
Status:                     confirmed
====================================================================== 
Date Submitted:             02-01-2006 23:22 PST
Last Modified:              02-02-2006 06:50 PST
====================================================================== 
Summary:                    modprobe incrorrectly reads module parametrs from
modules.conf
Description: 
ENABLE_FEATURE_MODPROBE_MULTIPLE_OPTIONS is set

modprobe.c - parse_command_string()
line 238
	*dst = xrealloc( *dst, strlen( *dst ) );
should be replaced with the line
	*dst = xrealloc( *dst, strlen( *dst ) + 1);

Because when reallocating buffer for the new parameter
the trailing zero (that is set in line 237) is'nt taken into account
This leads to a broken parameter string, that is returned thorugh
the dst parameter.

====================================================================== 

---------------------------------------------------------------------- 
 vicser - 02-02-06 03:50  
---------------------------------------------------------------------- 
More precise definition:

This issue concerns to Busybox 1.1.0 

---------------------------------------------------------------------- 
 vodz - 02-02-06 06:50  
---------------------------------------------------------------------- 
Please test 13797 revision. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
02-01-06 23:22  vicser         New Issue                                    
02-01-06 23:22  vicser         Status                   new => assigned     
02-01-06 23:22  vicser         Assigned To               => BusyBox         
02-01-06 23:24  vicser         Issue Monitored: vicser                      
02-02-06 03:50  vicser         Note Added: 0001026                          
02-02-06 06:50  vodz           Note Added: 0001027                          
02-02-06 06:50  vodz           Status                   assigned => confirmed
02-02-06 06:50  vodz           Resolution               open => fixed       
======================================================================




More information about the busybox-cvs mailing list