svn commit: trunk/busybox: archival networking

landley at busybox.net landley at busybox.net
Fri Aug 4 19:16:32 UTC 2006


Author: landley
Date: 2006-08-04 12:16:31 -0700 (Fri, 04 Aug 2006)
New Revision: 15776

Log:
Now that we have xopen3(), it's just plain unclean to have xopen() with
O_CREAT.  Two users are still doing it (and thus getting permissions 777),
I'm not sure what permissions they should be using but here they are
changed to xopen3().  This costs us a dozen or so bytes, but removing the
777 from xopen() should get some of that back.


Modified:
   trunk/busybox/archival/unzip.c
   trunk/busybox/networking/ftpgetput.c


Changeset:
Modified: trunk/busybox/archival/unzip.c
===================================================================
--- trunk/busybox/archival/unzip.c	2006-08-04 17:26:58 UTC (rev 15775)
+++ trunk/busybox/archival/unzip.c	2006-08-04 19:16:31 UTC (rev 15776)
@@ -333,7 +333,7 @@
 			overwrite = o_always;
 		case 'y': /* Open file and fall into unzip */
 			unzip_create_leading_dirs(dst_fn);
-			dst_fd = xopen(dst_fn, O_WRONLY | O_CREAT);
+			dst_fd = xopen(dst_fn, O_WRONLY | O_CREAT, 777);
 		case -1: /* Unzip */
 			if (verbosity == v_normal) {
 				printf("  inflating: %s\n", dst_fn);

Modified: trunk/busybox/networking/ftpgetput.c
===================================================================
--- trunk/busybox/networking/ftpgetput.c	2006-08-04 17:26:58 UTC (rev 15775)
+++ trunk/busybox/networking/ftpgetput.c	2006-08-04 19:16:31 UTC (rev 15776)
@@ -166,7 +166,7 @@
 		if (do_continue) {
 			fd_local = xopen(local_path, O_APPEND | O_WRONLY);
 		} else {
-			fd_local = xopen(local_path, O_CREAT | O_TRUNC | O_WRONLY);
+			fd_local = xopen3(local_path, O_CREAT | O_TRUNC | O_WRONLY, 777);
 		}
 	}
 




More information about the busybox-cvs mailing list