[BusyBox 0000168]: pidof, make -s optional and add optional -o

bugs at busybox.net bugs at busybox.net
Thu Oct 6 15:41:02 UTC 2005


The following issue has been CLOSED 
====================================================================== 
http://busybox.net/bugs/view.php?id=168 
====================================================================== 
Reported By:                bernhardf
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   168
Category:                   New Features
Reproducibility:            N/A
Severity:                   tweak
Priority:                   normal
Status:                     closed
Resolution:                 open
Fixed in Version:           
====================================================================== 
Date Submitted:             03-16-2005 14:11 PST
Last Modified:              10-06-2005 08:40 PDT
====================================================================== 
Summary:                    pidof, make -s optional and add optional -o
Description: 
For pidof, i want to make support for option -s (single shot) optional
instead of unconditional as it is now.
Also, this adds optional support for option -o (omit given pid).

Please consider reviewing and applying.
Thanks to Vladimir for pointing out alot of errors i managed to make.

====================================================================== 

---------------------------------------------------------------------- 
 bernhardf - 03-16-05 14:31  
---------------------------------------------------------------------- 
If -s and -o are not compiled into pidof.o.new, size stats are:
   text	   data	    bss	    dec	    hex	filename
    262	      0	      0	    262	    106	pidof.o.oorig
    236	      0	      0	    236	     ec	pidof.o.new

and in the cleanup, i foobared again.. :-(
The cleanup is obviously depending on the OMIT flag.

#ifdef CONFIG_FEATURE_CLEAN_UP
#ifdef CONFIG_FEATURE_PIDOF_OMIT

Sorry for that. 

---------------------------------------------------------------------- 
 bernhardf - 04-02-05 01:54  
---------------------------------------------------------------------- 
Correct macro for "option" in usage.h.
Make cleanup of omit dependant on CONFIG_FEATURE_PIDOF_OMIT.
Use llist_free() as introduced in issue http://busybox.net/bugs/view.php?id=204.


---------------------------------------------------------------------- 
 bernhardf - 10-06-05 08:40  
---------------------------------------------------------------------- 
checked in as rev. 11793 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
03-16-05 14:11  bernhardf      New Issue                                    
03-16-05 14:11  bernhardf      File Added: pidof-optional_args.3.diff           
        
03-16-05 14:31  bernhardf      Note Added: 0000090                          
04-02-05 01:54  bernhardf      Note Added: 0000127                          
04-02-05 01:54  bernhardf      File Added: pidof-optional_args.4.diff           
        
10-06-05 08:40  bernhardf      Status                   assigned => closed  
10-06-05 08:41  bernhardf      Note Added: 0000604                          
======================================================================




More information about the busybox-cvs mailing list