[BusyBox 0000115]: ifenslave

bugs at busybox.net bugs at busybox.net
Sat Nov 5 07:54:01 UTC 2005


A NOTE has been added to this issue. 
====================================================================== 
http://busybox.net/bugs/view.php?id=115 
====================================================================== 
Reported By:                marc
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   115
Category:                   New Features
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
====================================================================== 
Date Submitted:             02-18-2005 11:12 PST
Last Modified:              11-04-2005 23:54 PST
====================================================================== 
Summary:                    ifenslave
Description: 
>Attached a (trivial) patch to add ifenslave to the busybox program. I     
                    
>will add some more documentation in the next weeks (maybe months) to     
                     
>this applet, but currently it has all the documentation available with   
                     
>the ifenslave program.                                                   
                
>                                                                         
                     
>ifenslave allows to bind 2 (or more?) physical interfaces to one logical 
                     
>one, offering some level of redundancy.                                  
                     
>                                                                         
                     
>The patch is against 1.00                                                
                     
>                                                                         
                     
>P.S. I forwarded this to busybox-owner (I assumed I was on the busybox   
                     
>list but apparently, I was not). `(S)?h:H`.e can ignore that patch; it's 
                     
>essentially the same (only a different contact e-mail).  
====================================================================== 

---------------------------------------------------------------------- 
 marc - 03-25-05 04:55  
---------------------------------------------------------------------- 
The following patch needs to be applied, I need to restudy the term
'alphabetically ordered'.

/Me humbly throws himself at the mercy of the coding gods.

[mleeman at gemini busybox-1.00]$ cvs diff -up ./include/applets.h
Index: ./include/applets.h
===================================================================
RCS file:
/home/services/cvs/firmware/ppc/busybox-1.00/include/applets.h,v
retrieving revision 1.1
diff -u -p -r1.1 applets.h
--- ./include/applets.h 18 Feb 2005 11:19:47 -0000      1.1
+++ ./include/applets.h 25 Mar 2005 12:53:33 -0000
@@ -271,12 +271,12 @@
 #ifdef CONFIG_IFCONFIG
        APPLET(ifconfig, ifconfig_main, _BB_DIR_SBIN, _BB_SUID_NEVER)
 #endif
-#ifdef CONFIG_IFENSLAVE
-       APPLET(ifenslave, ifenslave_main, _BB_DIR_SBIN, _BB_SUID_NEVER)
-#endif
 #ifdef CONFIG_IFUPDOWN
        APPLET(ifdown, ifupdown_main, _BB_DIR_SBIN, _BB_SUID_NEVER)
 #endif
+#ifdef CONFIG_IFENSLAVE
+       APPLET(ifenslave, ifenslave_main, _BB_DIR_SBIN, _BB_SUID_NEVER)
+#endif
 #ifdef CONFIG_IFUPDOWN
        APPLET(ifup, ifupdown_main, _BB_DIR_SBIN, _BB_SUID_NEVER)
 #endif 

---------------------------------------------------------------------- 
 pgf - 08-04-05 13:08  
---------------------------------------------------------------------- 
i've done just enough on this to come up with a proper patch file
(ifenslave.pat), rather than the tar of individual diffs originally
provided.  and i've included the alphabetical reordering mentioned in the
other note.

however, this applet isn't ready for primetime, in my opinion.  it hasn't
been trimmed or modified at all, as far as i can tell, and makes no use of
the libbb.  someone should probably do some of that cleanup before this is
applied. 

---------------------------------------------------------------------- 
 marc - 08-04-05 13:27  
---------------------------------------------------------------------- 
IIRC, the individual diffs are mentioned in the rules for submitting
patches somewhere. I seem to remember this since I used the same for a
patch to u-boot and got slapped for this by Wolgang :)

As for the 'prime-time' note, ifenslave is pretty simple and though I
agree that it could be improved (everything can) it's not that needed
(ifenslave is one C file).

We're using the patch for euhm over 6 months in busybox and are pleased
with it. 

---------------------------------------------------------------------- 
 floydpink - 08-10-05 10:28  
---------------------------------------------------------------------- 
I made some changes to reduce size and fit better into Busybox.  This
resulted in a change from 14912 bytes to 7524 bytes on my system.

I attached a new unified patch with my changes. 

---------------------------------------------------------------------- 
 marc - 09-21-05 01:47  
---------------------------------------------------------------------- 
Refreshed work of Jason for the 1.01 

---------------------------------------------------------------------- 
 landley - 11-04-05 23:25  
---------------------------------------------------------------------- 
Guys, convince me here.  Why should I add this to busybox?  It's small and
self-contained ("gcc -Os -s linux-*/Documentation/networking/ifenslave.c"
produces a 14k binary), and there seems to be very little demand for it. 
(Where's the use case for this?  You have to buy twice as many switches,
so the cost savings aren't quite as much as they seem unless you're only
bonding two systems together directly sans switch.  GigE is cheap enough
that doing this for 100baseT makes very little sense anymore, and 10Gig is
expensive primarily because demand for it has failed to materialize.  Who
needs this and yet is concerned about an extra 7k in their binary?)

And yeah, the patch needs more work.  If it was fully busyboxified it
would use bb_getopts_ulflags(), bb_error_msg(), goto the end rather than
reproducing if(CLEAN_UP) and return, and so on...

But before worrying about that: where's the demand for this?  Examples? 

---------------------------------------------------------------------- 
 marc - 11-04-05 23:54  
---------------------------------------------------------------------- 
As for the busyboxification, some have done a bit of work, but I am willing
to have another look and continue this to the end.

I send you in e-mail and on the mailinglist some justification why we use
it (and I would assume the same for others); but in our case it boils down
to availability and reliability of the embedded systems by providing a
fallback physical connection bound to the same logical connection.

It has proven its worth in one particular network with very buggy
switches, and due to the critical nature of these devices, the fallback
allowed to plan an overhaul because of the extra time (switches were out
of our control).

Some customers opt for a full redundant network.

For embedded devices, I am truely convinced that a redundant ethernet
connection provides an added value; we double all our connections for the
afore mentioned reasons on all our boards... 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
02-18-05 11:12  marc           New Issue                                    
02-18-05 11:12  marc           File Added: ifenslave.tar.bz2                    
02-18-05 12:45  marc           Issue Monitored: marc                        
03-16-05 12:27  andersen       Assigned To              andersen => BusyBox 
03-25-05 04:55  marc           Note Added: 0000118                          
08-04-05 13:05  pgf            File Added: ifenslave.pat                    
08-04-05 13:08  pgf            Note Added: 0000382                          
08-04-05 13:27  marc           Note Added: 0000383                          
08-10-05 10:12  floydpink      File Added: ifenslave.patch                    
08-10-05 10:28  floydpink      Note Added: 0000400                          
09-21-05 01:46  marc           File Added: ifenslave-1.01.diff                  
 
09-21-05 01:47  marc           Note Added: 0000564                          
11-04-05 23:25  landley        Note Added: 0000665                          
11-04-05 23:54  marc           Note Added: 0000666                          
======================================================================




More information about the busybox-cvs mailing list