[BusyBox-cvs] [BusyBox 0000345]: `busybox' does not link when CONFIG_ETHER_WAKE=y

[bugs at busybox.net]

The following issue has been CLOSED 
====================================================================== 
http://busybox.net/bugs/view.php?id=345 
====================================================================== 
Reported By:                apgo
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   345
Category:                   Networking Support
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             07-20-2005 15:54 PDT
Last Modified:              07-31-2005 15:49 PDT
====================================================================== 
Summary:                    `busybox' does not link when CONFIG_ETHER_WAKE=y
Description: 
Function ether_hostton() not defined in uClibc, but declared at:

$uclibc/include/netinet/ether.h:45:extern int ether_hostton (__const char
*__hostname, struct ether_addr *__addr)


Busybox applet `ether-wake' makes call to said function at:

networking/ether-wake.c:243:          } else if (ether_hostton(hostid,
eaddr) == 0) {


Final linking of `busybox' fails with:

/tmp/test/busybox/networking/networking.a(ether-wake.o)(.text+0x29c): In
function `get_dest_addr':
: undefined reference to `ether_hostton'
collect2: ld returned 1 exit status
make: *** [busybox] Error 1

====================================================================== 

---------------------------------------------------------------------- 
 vapier - 07-20-05 15:56  
---------------------------------------------------------------------- 
or for the time being wrap it in
#if !defined(__uclibc__)
...
#endif 

---------------------------------------------------------------------- 
 apgo - 07-20-05 16:10  
---------------------------------------------------------------------- 
Updated patch attached. 

---------------------------------------------------------------------- 
 apgo - 07-20-05 16:19  
---------------------------------------------------------------------- 
Patch ifdef-out-ether_hostton-for-ether-wake-c.patch is a dud:

hubb at mars:/tmp/scratch/busybox$ echo foo | powerpc-linux-uclibc-gcc -E -dM
- | grep -i uclibc
hubb at mars:/tmp/scratch/busybox$
hubb at mars:/tmp/scratch/busybox$ powerpc-linux-uclibc-gcc -dumpversion
3.3.3
hubb at mars:/tmp/scratch/busybox$

 

---------------------------------------------------------------------- 
 vapier - 07-31-05 15:49  
---------------------------------------------------------------------- 
added to trunk, thanks 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-20-05 15:54  apgo           New Issue                                    
07-20-05 15:54  apgo           Status                   new => assigned     
07-20-05 15:54  apgo           Assigned To               => BusyBox         
07-20-05 15:54  apgo           File Added:
comment-out-ether_hostton-for-ether-wake-c.patch                    
07-20-05 15:56  vapier         Note Added: 0000332                          
07-20-05 16:10  apgo           File Added:
ifdef-out-ether_hostton-for-ether-wake-c.patch                    
07-20-05 16:10  apgo           Note Added: 0000333                          
07-20-05 16:17  apgo           Note Added: 0000334                          
07-20-05 16:18  apgo           Note Edited: 0000334                         
07-20-05 16:19  apgo           Note Edited: 0000334                         
07-20-05 16:22  apgo           Issue Monitored: apgo                        
07-31-05 15:49  vapier         Note Added: 0000360                          
07-31-05 15:49  vapier         Status                   assigned => closed  
07-31-05 15:49  vapier         Resolution               open => fixed       
======================================================================