[BusyBox 0000279]: [PATCH] On-demand net module loading fails with CONFIG_FEATURE_IFUPDOWN_IP

[bugs at busybox.net]

A NOTE has been added to this issue. 
====================================================================== 
http://busybox.net/bugs/view.php?id=279 
====================================================================== 
Reported By:                jean2
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   279
Category:                   Networking Support
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     assigned
====================================================================== 
Date Submitted:             06-02-2005 15:03 PDT
Last Modified:              08-29-2005 09:31 PDT
====================================================================== 
Summary:                    [PATCH] On-demand net module loading fails with
CONFIG_FEATURE_IFUPDOWN_IP
Description: 
Kernel modules autoloading of network driver doesn't work when ifup use ip
to configure the interface. This feature is useful because it allow to
load the network driver only when it's configured in
/etc/network/interfaces, to
minimise kernel memory footprint and power consumption.

The basic problem is that 'ip' is not designed to support module
autoloading. This problem is most likely present upstream as well, however
all distros I know use ifconfig from ifup (and not ip), which is why
probably nobody noticed it.

The fix is pretty safe, if we don't find the interface in our cache, we
explicitely request it from the kernel.

Patch is attached. I made the patch for busybox-1.00 and fully tested
there, but I've verified that it applies smoothly and compile with the
02-june-05 snapshot.

Jean

====================================================================== 

---------------------------------------------------------------------- 
 mdeschamps - 08-09-05 02:41  
---------------------------------------------------------------------- 
Please give away patches as patches not as exercices ! 

---------------------------------------------------------------------- 
 jean2 - 08-29-05 09:31  
---------------------------------------------------------------------- 
mdeschamps wrote :
> 
> Please give away patches as patches not as exercices !

    Would you mind to clarify ? I can see that you have not tested the
patch, neither understood what it does.
    The patch is fully functional and fully tested, and a very similar
patch has been included upstream. The only exercise left to the reader is
a minor optimisation thast does not matter in real life (especially in the
context of memory constrained systems).
    Jean 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-02-05 15:03  jean2          New Issue                                    
06-02-05 15:03  jean2          File Added: busybox-ip-module-loading.patch      
             
08-09-05 02:41  mdeschamps     Note Added: 0000397                          
08-29-05 09:31  jean2          Note Added: 0000470                          
======================================================================