[BusyBox-cvs] svn commit: trunk/busybox/archival

vapier at busybox.net vapier at busybox.net
Sat Apr 23 01:43:07 UTC 2005


Author: vapier
Date: 2005-04-22 19:43:07 -0600 (Fri, 22 Apr 2005)
New Revision: 10155

Log:
add comments about ignoring some warnings which are OK

Modified:
   trunk/busybox/archival/rpm.c


Changeset:
Modified: trunk/busybox/archival/rpm.c
===================================================================
--- trunk/busybox/archival/rpm.c	2005-04-23 01:42:29 UTC (rev 10154)
+++ trunk/busybox/archival/rpm.c	2005-04-23 01:43:07 UTC (rev 10155)
@@ -260,12 +260,16 @@
 int bsearch_rpmtag(const void *key, const void *item)
 {
 	rpm_index **tmp = (rpm_index **) item;
+	/* gcc throws warnings here when sizeof(void*)!=sizeof(int) ...
+	 * it's ok to ignore it because this isn't a 'real' pointer */
 	return ((int) key - tmp[0]->tag);
 }
 
 int rpm_getcount(int tag)
 {
 	rpm_index **found;
+	/* gcc throws warnings here when sizeof(void*)!=sizeof(int) ...
+	 * it's ok to ignore it because tag won't be used as a pointer */
 	found = bsearch((void *) tag, mytags, tagcount, sizeof(struct rpmtag *), bsearch_rpmtag);
 	if (!found) return 0;
 	else return found[0]->count;
@@ -274,6 +278,8 @@
 char *rpm_getstring(int tag, int itemindex)
 {
 	rpm_index **found;
+	/* gcc throws warnings here when sizeof(void*)!=sizeof(int) ...
+	 * it's ok to ignore it because tag won't be used as a pointer */
 	found = bsearch((void *) tag, mytags, tagcount, sizeof(struct rpmtag *), bsearch_rpmtag);
 	if (!found || itemindex >= found[0]->count) return NULL;
 	if (found[0]->type == RPM_STRING_TYPE || found[0]->type == RPM_I18NSTRING_TYPE || found[0]->type == RPM_STRING_ARRAY_TYPE) {
@@ -288,6 +294,8 @@
 {
 	rpm_index **found;
 	int n, *tmpint;
+	/* gcc throws warnings here when sizeof(void*)!=sizeof(int) ...
+	 * it's ok to ignore it because tag won't be used as a pointer */
 	found = bsearch((void *) tag, mytags, tagcount, sizeof(struct rpmtag *), bsearch_rpmtag);
 	if (!found || itemindex >= found[0]->count) return -1;
 	tmpint = (int *) (map + found[0]->offset);




More information about the busybox-cvs mailing list