[BusyBox-cvs] CVS busybox

CVS User andersen andersen at codepoet.org
Wed Oct 13 09:42:10 UTC 2004


Update of /var/cvs/busybox
In directory nail:/tmp/cvs-serv2345

Modified Files:
	Changelog 
Log Message:
prepare for release


--- /var/cvs/busybox/Changelog	2004/08/16 10:29:28	1.295
+++ /var/cvs/busybox/Changelog	2004/10/13 09:42:09	1.296
@@ -1,675 +1,1281 @@
 ---------------------
-PatchSet 4304 
-Date: 2004/07/26 11:45:25
+PatchSet 4347 
+Date: 2004/08/16 10:29:28
 Author: andersen
 Branch: HEAD
-Tag: (none) 
+Tag: busybox_1_00_rc3 
 Log:
-Make certain that udhcp shuts down the interface
+Prepare for release
 
 Members: 
-	networking/ifupdown.c:1.43->1.44 
+	Changelog:1.294->1.295 
+	docs/busybox_header.pod:1.17->1.18 
+	docs/busybox.net/news.html:1.21->1.22 
+	docs/busybox.net/screenshot.html:1.11->1.12 
 
 ---------------------
-PatchSet 4305 
-Date: 2004/07/26 11:45:47
+PatchSet 4348 
+Date: 2004/08/18 17:57:16
 Author: andersen
 Branch: HEAD
 Tag: (none) 
 Log:
-bump version to -rc2
+Fixup 'dc' usage
 
 Members: 
-	Rules.mak:1.33->1.34 
+	include/usage.h:1.218->1.219 
 
 ---------------------
-PatchSet 4306 
-Date: 2004/07/26 11:46:50
+PatchSet 4349 
+Date: 2004/08/19 18:22:13
 Author: andersen
 Branch: HEAD
 Tag: (none) 
 Log:
-oops
+Patch from Vladimir N. Oleynik:
+
+On Wed Aug 18, 2004 at 06:52:57PM +0800, Matt Johnston wrote:
+> I've come across some strange-seeming behaviour when running programs
+> under Busybox (1.0.0-rc3) ash. If the child process sets stdin to be
+> non-blocking and then exits, the parent ash will also exit. A quick strace
+> shows that a subsequent read() from stdin returns EAGAIN (as would be
+> expected):
+
+Thanks!
+Patch attached.
+
+
+--w
+vodz
 
 Members: 
-	networking/ifupdown.c:1.44->1.45 
+	shell/ash.c:1.104->1.105 
+	shell/cmdedit.c:1.92->1.93 
 
 ---------------------
-PatchSet 4307 
-Date: 2004/07/26 12:05:12
+PatchSet 4350 
+Date: 2004/08/19 18:25:02
 Author: andersen
 Branch: HEAD
 Tag: (none) 
 Log:
-YAEGASHI Takeshi writes:
-
-Hi,
-
-With the following /etc/fstab (any two or more lines of nfs), mount -a
--t nfs causes a segmentation faults.
+Patch from Tito documenting the '-q' option
 
-server:/exports/aaa /mnt/aaa nfs defaults 0 0
-server:/exprots/bbb /mnt/bbb nfs defaults 0 0
+Members: 
+	include/usage.h:1.219->1.220 
 
-In util-linux/nfsmount.c, it overwrites malloc'ed pointer *mount_opts
-with a static pointer.  With this patch it does proper memory realloc
-and data copy instead.
+---------------------
+PatchSet 4351 
+Date: 2004/08/19 18:26:26
+Author: andersen
+Branch: HEAD
+Tag: (none) 
+Log:
+Patch from Tito adding support for '-q'
 
 Members: 
-	util-linux/nfsmount.c:1.27->1.28 
+	procps/kill.c:1.52->1.53 
 
 ---------------------
-PatchSet 4308 
-Date: 2004/07/26 12:05:44
+PatchSet 4352 
+Date: 2004/08/19 18:30:31
 Author: andersen
 Branch: HEAD
 Tag: (none) 
 Log:
-Make certain that udhcp shuts down the interface
+Patch from Mike Castle to cleanup some modutils issues, in
+particular making alias support work better.
 
 Members: 
-	networking/ifupdown.c:1.45->1.46 
+	modutils/modprobe.c:1.39->1.40 
 
 ---------------------
-PatchSet 4309 
-Date: 2004/07/26 12:06:19
+PatchSet 4353 
+Date: 2004/08/19 19:15:06
 Author: andersen
 Branch: HEAD
 Tag: (none) 
 Log:
-Allow hex escape sequences
+regularly update the status line display
+ -Erik
 
 Members: 
-	libbb/process_escape_sequence.c:1.6->1.7 
+	editors/vi.c:1.37->1.38 
 
 ---------------------
-PatchSet 4310 
-Date: 2004/07/26 12:07:01
+PatchSet 4354 
+Date: 2004/08/19 19:17:30
 Author: andersen
 Branch: HEAD
 Tag: (none) 
 Log:
-Prepare for release
+Patch from Rodney Radford adding x86_64 support.
 
 Members: 
-	Changelog:1.293->1.294 
-	Rules.mak:1.34->1.35 
-	docs/busybox.net/news.html:1.19->1.20 
+	modutils/insmod.c:1.122->1.123 
 
 ---------------------
-PatchSet 4311 
-Date: 2004/07/26 12:11:32
-Author: andersen
+PatchSet 4355 
+Date: 2004/08/25 02:02:19
+Author: bug1
 Branch: HEAD
 Tag: (none) 
 Log:
-bother.  unrevert my fix.
+Patch from Manousaridis Angelos to cleanup stale file descriptors, it was preventing unmounting an initial filesystem.
 
 Members: 
-	libbb/process_escape_sequence.c:1.7->1.8 
-	networking/ifupdown.c:1.46->1.47 
+	loginutils/getty.c:1.13->1.14 
+	loginutils/login.c:1.19->1.20 
 
 ---------------------
-PatchSet 4312 
-Date: 2004/07/26 12:12:06
+PatchSet 4356 
+Date: 2004/08/26 21:45:21
 Author: andersen
 Branch: HEAD
 Tag: (none) 
 Log:
-bump version to -rc2
+Felipe Kellermann writes:
+
+Unfortunatelly I've not followed the last two or three weeks commits (new
+semester started and so now I rarely have time to fix my personal bridge)
+but tonight I synched my tree and immediately noticed a rather nasty bug!
+
+[Using libbb/interface.c:1.24]
+# grep eth0 /proc/net/dev | xargs
+eth0:311708397 237346 1670 0 1789 1670 0 0 22580308 120297 0 0 0 102 0 0
+
+# ifconfig eth0
+eth0      Link encap:Ethernet  HWaddr 00:20:AF:7C:EA:B7
+          inet addr:10.0.0.1  Bcast:10.0.0.127  Mask:255.255.255.128
+          UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
+          RX packets:0 errors:0 dropped:0 overruns:0 frame:0
+          TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
+          collisions:0 txqueuelen:1000
+          RX bytes:0 (0.0 B)  TX bytes:0 (0.0 B)
+          Interrupt:5 Base address:0x320
+
+
+All values `ifconfig' is showing are `zeroed' -- I quickly looked at the
+last commits I missed and noticed that there were a commit relating to
+ifconfig, libbb/interface.c:1.23->1.24 (PatchSet 4338).
+
+I've reversed the patch and now everything is working again.  I compared
+the get_name's return values from the 1.23 and 1.24 and quickly noticed
+that the new revision is leaving `p' right on the sep while the rev 1.23
+was leaving it right on the starting of the values...
+
+1-line, 1/3-minute patch attached  :-)
 
 Members: 
-	Rules.mak:1.35->1.36 
+	libbb/interface.c:1.24->1.25 
 
 ---------------------
-PatchSet 4313 
-Date: 2004/07/26 12:22:33
+PatchSet 4357 
+Date: 2004/08/26 22:18:56
 Author: andersen
 Branch: HEAD
-Tag: busybox_1_00_rc2 
+Tag: (none) 
 Log:
-add missing ;
+Tito writes:
+
+Hi,
+I've spent the half night staring at the devilish  my_getpwuid and my_getgrgid functions
+trying to find out a way to avoid actual and future potential buffer overflow problems
+without breaking existing code.
+Finally I've  found a not intrusive way to do this that surely doesn't break existing code
+and fixes a couple of problems too.
+The attached patch:
+1) changes the behaviour of my_getpwuid and my_getgrgid to avoid potetntial buffer overflows
+2) fixes all occurences of this function calls in tar.c , id.c , ls.c, whoami.c, logger.c, libbb.h.
+3) The behaviour of tar, ls and  logger is unchanged.
+4) The behavior of ps with somewhat longer usernames messing up output is fixed.
+5) The only bigger change was the increasing of size of the buffers in id.c to avoid
+     false negatives (unknown user: xxxxxx) with usernames longer than 8 chars.
+     The value i used ( 32 chars ) was taken from the tar header ( see gname and uname).
+     Maybe this buffers can be reduced a bit  ( to 16 or whatever ), this is up to you.
+6) The increase of size of the binary is not so dramatic:
+     size busybox
+       text    data     bss     dec     hex filename
+     239568    2300   36816  278684   4409c busybox
+    size busybox_fixed
+       text    data     bss     dec     hex filename
+     239616    2300   36816  278732   440cc busybox
+7) The behaviour of whoami changed:
+    actually it  prints out an username cut down to the size of the buffer.
+    This could be fixed by increasing the size of the buffer as in id.c or
+    avoid the use of my_getpwuid and use getpwuid directly instead.
+    Maybe this colud be also remain unchanged......
+
+Please apply if you think it is ok to do so.
+The diff applies on today's cvs tarball (2004-08-25).
+Thanks in advance,
+Ciao,
+Tito
 
 Members: 
-	networking/ifupdown.c:1.47->1.48 
+	archival/tar.c:1.194->1.195 
+	coreutils/id.c:1.24->1.25 
+	coreutils/ls.c:1.110->1.111 
+	coreutils/whoami.c:1.21->1.22 
+	include/libbb.h:1.133->1.134 
+	libbb/my_getgrgid.c:1.7->1.8 
+	libbb/my_getpwuid.c:1.7->1.8 
+	libbb/procps.c:1.13->1.14 
+	sysklogd/logger.c:1.39->1.40 
 
 ---------------------
-PatchSet 4314 
-Date: 2004/07/26 18:57:49
-Author: sandman
+PatchSet 4358 
+Date: 2004/08/26 22:22:50
+Author: andersen
 Branch: HEAD
 Tag: (none) 
 Log:
-document stuff I have done
+Vladimir N. Oleynik writes:
+
+Ming-Ching,
+
+>>No. Here there are no mistakes.
+>>You using POST metod.
+>>For get data you should read from stdin CONTENT_LENGTH bytes.
+
+>Hower as I posted a little while ago, there is indeed a bug
+>in POST method if the CONTENT_LENGTH is bigger
+>than sizeof(wbuf[128]). So if your CGI script is expecting to
+>read the full CONTENT_LENGTH, it might block forever,
+>because it will only transfer sizeof(wbuf) to the CGI.
+
+Ok, Ok. I should find time to understand with a problem.
+Try attached patch.
+
+
+--w
+vodz
 
 Members: 
-	AUTHORS:1.45->1.46 
+	networking/httpd.c:1.26->1.27 
 
 ---------------------
-PatchSet 4315 
-Date: 2004/07/27 16:45:46
+PatchSet 4359 
+Date: 2004/08/26 22:26:26
 Author: andersen
 Branch: HEAD
 Tag: (none) 
 Log:
-Felipe Kellermann noticed a missing `break'.
+Save a line or two
 
 Members: 
-	libbb/process_escape_sequence.c:1.8->1.9 
+	loginutils/getty.c:1.14->1.15 
+	loginutils/login.c:1.20->1.21 
 
 ---------------------
-PatchSet 4316 
-Date: 2004/07/28 19:15:04
+PatchSet 4360 
+Date: 2004/08/26 22:36:02
 Author: andersen
 Branch: HEAD
 Tag: (none) 
 Log:
-Thanks to Ken Roberts, fix the slackware url
+Tito writes:
+
+Hi,
+I've fixed also the issue of whoami cutting down usernames.
+This time I cannot send a diff because i don't know if my previous patches will be applied
+or not, so I send in the whole file.
+The changes I've made don't affect size but ensure that usernames of whatever lenght
+are correctly displayed.
+root at localhost:/dev/pts/3:/root/Desktop/busybox/coreutils# size whoami_orig.o
+   text    data     bss     dec     hex filename
+    102       0       0     102      66 whoami_orig.o
+root at localhost:/dev/pts/3:/root/Desktop/busybox/coreutils# size whoami.o
+   text    data     bss     dec     hex filename
+     93       0       0      93      5d whoami.o
+
+This should be applied even if the other patches aren't as this matches the behaviour of the  GNU whoami.
+
+Thanks in advance,
+Ciao,
+Tito
 
 Members: 
-	docs/busybox.net/products.html:1.11->1.12 
+	coreutils/whoami.c:1.22->1.23 
 
 ---------------------
-PatchSet 4317 
-Date: 2004/07/29 23:15:16
-Author: mjn3
+PatchSet 4361 
+Date: 2004/08/26 23:01:34
+Author: andersen
 Branch: HEAD
 Tag: (none) 
 Log:
-Clean up hex escape support.
+The login applet should always be setuid root
 
 Members: 
-	libbb/process_escape_sequence.c:1.9->1.10 
+	include/applets.h:1.114->1.115 
 
 ---------------------
-PatchSet 4318 
-Date: 2004/07/30 14:31:01
+PatchSet 4362 
+Date: 2004/08/26 23:13:00
 Author: andersen
 Branch: HEAD
 Tag: (none) 
 Log:
-As noted by Eric Spakman, calling static_down() and then calling
-bootp_down() seems redundant, esp since bootp_down was a subset

[1288 lines skipped]



More information about the busybox-cvs mailing list