[BusyBox-cvs] CVS update of busybox/networking (ifupdown.c)
Erik Andersen
andersen at codepoet.org
Fri Jul 30 14:31:02 UTC 2004
Date: Friday, July 30, 2004 @ 08:31:02
Author: andersen
Path: /var/cvs/busybox/networking
Modified: ifupdown.c (1.48 -> 1.49)
As noted by Eric Spakman, calling static_down() and then calling
bootp_down() seems redundant, esp since bootp_down was a subset
of static_down, so just use that...
Index: busybox/networking/ifupdown.c
diff -u busybox/networking/ifupdown.c:1.48 busybox/networking/ifupdown.c:1.49
--- busybox/networking/ifupdown.c:1.48 Mon Jul 26 06:22:33 2004
+++ busybox/networking/ifupdown.c Fri Jul 30 08:31:01 2004
@@ -551,21 +551,12 @@
return(0);
}
-static int bootp_down(struct interface_defn_t *ifd, execfn *exec)
-{
-#ifdef CONFIG_FEATURE_IFUPDOWN_IP
- return(execute("ip link set %iface% down", ifd, exec));
-#else
- return(execute("ifconfig %iface% down", ifd, exec));
-#endif
-}
-
static int dhcp_down(struct interface_defn_t *ifd, execfn *exec)
{
int result = 0;
if (execable("/sbin/udhcpc")) {
- execute("kill -USR2 `cat /var/run/udhcpc.%iface%.pid` 2>/dev/null", ifd, exec);
- execute("kill -9 `cat /var/run/udhcpc.%iface%.pid` 2>/dev/null", ifd, exec);
+ result = execute("kill -USR2 `cat /var/run/udhcpc.%iface%.pid` 2>/dev/null", ifd, exec);
+ result += execute("kill -9 `cat /var/run/udhcpc.%iface%.pid` 2>/dev/null", ifd, exec);
} else if (execable("/sbin/pump")) {
result = execute("pump -i %iface% -k", ifd, exec);
} else if (execable("/sbin/dhclient")) {
@@ -573,8 +564,7 @@
} else if (execable("/sbin/dhcpcd")) {
result = execute("dhcpcd -k %iface%", ifd, exec);
}
- static_down(ifd, exec);
- return (result || bootp_down(ifd, exec));
+ return (result || static_down(ifd, exec));
}
static int bootp_up(struct interface_defn_t *ifd, execfn *exec)
@@ -611,7 +601,7 @@
{ "wvdial", wvdial_up, wvdial_down, },
{ "ppp", ppp_up, ppp_down, },
{ "static", static_up, static_down, },
- { "bootp", bootp_up, bootp_down, },
+ { "bootp", bootp_up, static_down, },
{ "dhcp", dhcp_up, dhcp_down, },
{ "loopback", loopback_up, loopback_down, },
};
More information about the busybox-cvs
mailing list