<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body>
<p>Hello,<br>
</p>
<div class="moz-cite-prefix">On 04.03.2021 16:25, Adrian Perez de
Castro wrote:<br>
</div>
<blockquote type="cite" cite="mid:20210304172503.GB743912@momiji">
<pre class="moz-quote-pre" wrap="">Hello Adrian,
On Mon, 01 Mar 2021 16:55:49 +0000 Adrian Sweet <a class="moz-txt-link-rfc2396E" href="mailto:asweet@thegoodpenguin.co.uk"><asweet@thegoodpenguin.co.uk></a> wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">All,
Is there anything preventing this being merged? Can I help with any issues?
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
The patch looks good to me (hence the "Reviewed-by" tag I sent earlier).
What is left is for a Buildroot maintainer to merge it---if they agree that
the patch is good to go :)
Cheers,
-Adrian
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Thanks, Adrian
On Thu, 4 Feb 2021 at 20:33, Adrian Perez de Castro <a class="moz-txt-link-rfc2396E" href="mailto:aperez@igalia.com"><aperez@igalia.com></a>
wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Hi Adrian,
Thanks for the patch, I think adding the option is fine given that there
are people around who would use it—which seems to be the case.
Unless somebody else has an opinion against, I think we could merge this
change =]
On Tue, 02 Feb 2021 11:57:21 +0000 Adrian Sweet <
<a class="moz-txt-link-abbreviated" href="mailto:asweet@thegoodpenguin.co.uk">asweet@thegoodpenguin.co.uk</a>> wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Added config option to expose browser remote control on the D-Bus system
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">bus
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
Signed-off-by: Adrian Sweet <a class="moz-txt-link-rfc2396E" href="mailto:asweet@thegoodpenguin.co.uk"><asweet@thegoodpenguin.co.uk></a>
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Reviewed-by: Adrian Perez de Castro <a class="moz-txt-link-rfc2396E" href="mailto:aperez@igalia.com"><aperez@igalia.com></a>
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">---
package/cog/Config.in | 6 ++++++
package/cog/cog.mk | 6 ++++++
2 files changed, 12 insertions(+)
diff --git a/package/cog/Config.in b/package/cog/Config.in
index a9ca7473a9..c19f1c200e 100644
--- a/package/cog/Config.in
+++ b/package/cog/Config.in
@@ -47,6 +47,12 @@ config BR2_PACKAGE_COG_PLATFORM_DRM
with video drivers that support kernel mode-setting (KMS)
via the DRM user-space API.
+config BR2_PACKAGE_COG_USE_SYSTEM_DBUS
+ bool "Use D-Bus system bus"
+ default n</pre>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
<p>That's superfluous, boolean will default to n.</p>
Best<br>
Bartek<br>
<blockquote type="cite" cite="mid:20210304172503.GB743912@momiji">
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
+ help
+ Expose remote control interface on system bus
+
comment "DRM platform needs mesa3d w/ EGL driver and GBM"
depends on !BR2_PACKAGE_MESA3D_OPENGL_EGL
diff --git a/package/cog/cog.mk b/package/cog/cog.mk
index 47a5573dda..c5a1cc0df2 100644
--- a/package/cog/cog.mk
+++ b/package/cog/cog.mk
@@ -31,4 +31,10 @@ else
COG_CONF_OPTS += -DCOG_PLATFORM_DRM=OFF
endif
+ifeq ($(BR2_PACKAGE_COG_USE_SYSTEM_DBUS),y)
+COG_CONF_OPTS += -DCOG_DBUS_SYSTEM_BUS=ON
+else
+COG_CONF_OPTS += -DCOG_DBUS_SYSTEM_BUS=OFF
+endif
+
$(eval $(cmake-package))
--
2.25.1
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
--
Adrian Sweet, Software Engineer
<a class="moz-txt-link-freetext" href="https://www.thegoodpenguin.co.uk">https://www.thegoodpenguin.co.uk</a>
The Good Penguin Ltd is a company registered in England and Wales with
company number 12374667 and VAT number 341687879. Registered office: The
Good Penguin Ltd, Westcott, Glasllwch Lane, Newport, NP20 3PS.
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
buildroot mailing list
<a class="moz-txt-link-abbreviated" href="mailto:buildroot@busybox.net">buildroot@busybox.net</a>
<a class="moz-txt-link-freetext" href="http://lists.busybox.net/mailman/listinfo/buildroot">http://lists.busybox.net/mailman/listinfo/buildroot</a>
</pre>
</blockquote>
</blockquote>
</body>
</html>