<div dir="ltr"><div dir="ltr">Hi Romain,<div><br></div><div>Thank you. I just submit another patch <a href="https://patchwork.ozlabs.org/project/buildroot/patch/20201215004903.8829-1-xuminready@gmail.com/">configs/rock64: update defconfig</a> to replace these two patches.</div><div><br></div><div>The original u-boot is also from ayufan-rock64. I tested the ayufan-rock64/linux-mainline-u-boot. No compile error, and it works on my Rock64 board.</div><div><br></div><div>Thanks</div><div>Min</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Dec 14, 2020 at 2:08 PM Romain Naour <<a href="mailto:romain.naour@gmail.com">romain.naour@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello Min,<br>
<br>
Adding Michal in Cc.<br>
<br>
Le 14/12/2020 à 20:23, Min Xu a écrit :<br>
> Signed-off-by: Min Xu <<a href="mailto:xuminready@gmail.com" target="_blank">xuminready@gmail.com</a>><br>
<br>
Please squash your two patches since you add again this defconfig with an<br>
updated BSP. As explained in the commit log [1] the rock64 defconfig was removed<br>
since it was broken for a long time due to a too old uboot version (2017.09).<br>
<br>
Also this is not really a fix since you bump uboot from 2017.09 to 2020.07 from<br>
ayufan-rock64 fork.<br>
<br>
[1] a5fa2469e6506ea4f5a91739aa099f63a10e45ce<br>
<br>
Best regards,<br>
Romain<br>
<br>
<br>
> ---<br>
>  configs/rock64_defconfig | 8 ++++----<br>
>  1 file changed, 4 insertions(+), 4 deletions(-)<br>
> <br>
> diff --git a/configs/rock64_defconfig b/configs/rock64_defconfig<br>
> index 30bf12c061..df03e357e2 100644<br>
> --- a/configs/rock64_defconfig<br>
> +++ b/configs/rock64_defconfig<br>
> @@ -17,16 +17,16 @@ BR2_TARGET_ROOTFS_EXT2=y<br>
>  BR2_TARGET_ROOTFS_EXT2_4=y<br>
>  BR2_TARGET_ROOTFS_EXT2_SIZE="128M"<br>
>  BR2_TARGET_ARM_TRUSTED_FIRMWARE=y<br>
> -BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION=y<br>
> -BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION_VALUE="v1.4"<br>
>  BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="rk3328"<br>
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES="bl31/*.elf"<br>
>  BR2_TARGET_UBOOT=y<br>
>  BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y<br>
>  BR2_TARGET_UBOOT_CUSTOM_GIT=y<br>
> -BR2_TARGET_UBOOT_CUSTOM_REPO_URL="<a href="https://github.com/ayufan-rock64/linux-u-boot.git" rel="noreferrer" target="_blank">https://github.com/ayufan-rock64/linux-u-boot.git</a>"<br>
> -BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="2017.09-rockchip-ayufan-1035-gd646df03ac"<br>
> +BR2_TARGET_UBOOT_CUSTOM_REPO_URL="<a href="https://github.com/ayufan-rock64/linux-mainline-u-boot.git" rel="noreferrer" target="_blank">https://github.com/ayufan-rock64/linux-mainline-u-boot.git</a>"<br>
> +BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="release-2020-07"<br>
>  BR2_TARGET_UBOOT_BOARD_DEFCONFIG="rock64-rk3328"<br>
>  BR2_TARGET_UBOOT_NEEDS_DTC=y<br>
> +BR2_TARGET_UBOOT_NEEDS_PYTHON3=y<br>
>  BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y<br>
>  BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y<br>
>  BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF=y<br>
> <br>
<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div><b><font face="arial, helvetica, sans-serif"><br></font></b></div><div><b><font face="arial, helvetica, sans-serif">Best Regards</font></b></div><div><b><font face="arial, helvetica, sans-serif"><br></font></b></div><b><font face="arial, helvetica, sans-serif">XuMin's Ready!</font></b></div></div>