<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Le mer. 18 sept. 2019 à 09:35, Thomas Petazzoni <<a href="mailto:thomas.petazzoni@bootlin.com">thomas.petazzoni@bootlin.com</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Wed, 18 Sep 2019 08:19:12 +0200<br>
Francois Perrad <<a href="mailto:fperrad@gmail.com" target="_blank">fperrad@gmail.com</a>> wrote:<br>
<br>
> Signed-off-by: Francois Perrad <<a href="mailto:francois.perrad@gadz.org" target="_blank">francois.perrad@gadz.org</a>><br>
> ---<br>
>  package/lsqlite3/<a href="http://lsqlite3.mk" rel="noreferrer" target="_blank">lsqlite3.mk</a>             | 1 +<br>
>  package/lua-curl/<a href="http://lua-curl.mk" rel="noreferrer" target="_blank">lua-curl.mk</a>             | 1 +<br>
>  package/lua-flu/<a href="http://lua-flu.mk" rel="noreferrer" target="_blank">lua-flu.mk</a>               | 3 +++<br>
>  package/lua-iconv/<a href="http://lua-iconv.mk" rel="noreferrer" target="_blank">lua-iconv.mk</a>           | 1 +<br>
>  package/luadbi-sqlite3/<a href="http://luadbi-sqlite3.mk" rel="noreferrer" target="_blank">luadbi-sqlite3.mk</a> | 1 +<br>
>  package/luaexpat/<a href="http://luaexpat.mk" rel="noreferrer" target="_blank">luaexpat.mk</a>             | 1 +<br>
>  package/luaossl/<a href="http://luaossl.mk" rel="noreferrer" target="_blank">luaossl.mk</a>               | 3 +++<br>
>  package/luasec/<a href="http://luasec.mk" rel="noreferrer" target="_blank">luasec.mk</a>                 | 1 +<br>
>  package/luasql-sqlite3/<a href="http://luasql-sqlite3.mk" rel="noreferrer" target="_blank">luasql-sqlite3.mk</a> | 1 +<br>
>  package/wsapi-fcgi/<a href="http://wsapi-fcgi.mk" rel="noreferrer" target="_blank">wsapi-fcgi.mk</a>         | 1 +<br>
>  10 files changed, 14 insertions(+)<br>
> <br>
> diff --git a/package/lsqlite3/<a href="http://lsqlite3.mk" rel="noreferrer" target="_blank">lsqlite3.mk</a> b/package/lsqlite3/<a href="http://lsqlite3.mk" rel="noreferrer" target="_blank">lsqlite3.mk</a><br>
> index bbf6a1db1..51f9516fd 100644<br>
> --- a/package/lsqlite3/<a href="http://lsqlite3.mk" rel="noreferrer" target="_blank">lsqlite3.mk</a><br>
> +++ b/package/lsqlite3/<a href="http://lsqlite3.mk" rel="noreferrer" target="_blank">lsqlite3.mk</a><br>
> @@ -8,5 +8,6 @@ LSQLITE3_VERSION = 0.9.5-1<br>
>  LSQLITE3_SUBDIR = lsqlite3_fsl09y<br>
>  LSQLITE3_LICENSE = MIT<br>
>  LSQLITE3_DEPENDENCIES = sqlite<br>
> +LSQLITE3_BUILD_OPTS = SQLITE_DIR="$(STAGING_DIR)/usr"<br>
<br>
I'm not sure to understand this change. It seems a bit redundant for<br>
all those packages to say "the native libraries you need are in<br>
$(STAGING_DIR)/usr", since native libraries are always there. Why isn't<br>
the common infrastructure taking care of this ?<br>
<br></blockquote><div><br></div><div>Yes, it looks redundant.<br>_BUILD_OPT contains a list of key/value,<br>the value is always the same ($(STAGING_DIR)/usr),<br>but the key (SQLITE_DIR in this case) depends of the rock.<br>   <br>This is the LuaRocks way.</div><div><br></div><div>François</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Thomas<br>
-- <br>
Thomas Petazzoni, CTO, Bootlin<br>
Embedded Linux and Kernel engineering<br>
<a href="https://bootlin.com" rel="noreferrer" target="_blank">https://bootlin.com</a><br>
_______________________________________________<br>
buildroot mailing list<br>
<a href="mailto:buildroot@busybox.net" target="_blank">buildroot@busybox.net</a><br>
<a href="http://lists.busybox.net/mailman/listinfo/buildroot" rel="noreferrer" target="_blank">http://lists.busybox.net/mailman/listinfo/buildroot</a><br>
</blockquote></div></div>