<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0"></p>
<div><br>
</div>
<div>Hello <font style="font-size:11pt" face="Calibri, sans-serif" color="#000000">
Thomas</font>,</div>
<div><br>
</div>
<div>sorry for the mess. It was necessary to resend the "git send-mail" via Microsoft office, which caused the formatting problems (excluding the missing new lines).</div>
<div><br>
</div>
<div>But the big problem is the build. I noticed that in the current buildroot version is nothing like "<span>BR2_PACKAGE_BOOST_ARCH_SUPPORTS</span>", as you already mentioned. But I am working on buildroot "<span>2016.05, Released May 31st, 2016</span>" (see
 [1]). The testing under "<span>2016.05</span>" went fine, but I do not have a config to test it on the latest buildroot version.</div>
<div><br>
</div>
<div>In this case my patch will not be compatible to the latest version. Is there a option to handle this case or should we cancel this process?<br>
</div>
<div><br>
</div>
<div><br>
</div>
<div>[1]:<br>
</div>
<div>Symbol: BR2_PACKAGE_BOOST_ARCH_SUPPORTS [=y]<br>
   Type  : boolean<br>
   Defined at package/boost/Config.in:4</div>
<br>
<p></p>
<br>
<br>
<div style="color: rgb(0, 0, 0);">
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>Von:</b> Thomas Petazzoni <thomas.petazzoni@bootlin.com><br>
<b>Gesendet:</b> Samstag, 15. Dezember 2018 15:14<br>
<b>An:</b> Brenke, Maik<br>
<b>Cc:</b> buildroot@buildroot.org<br>
<b>Betreff:</b> Re: [Buildroot] WG: [PATCH] package/vsomeip: new package</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Hello Maik,<br>
<br>
On Wed, 12 Dec 2018 07:53:11 +0000, Brenke, Maik wrote:<br>
> From: Maik Brenke <maik.brenke@continental-corporation.com><br>
> <br>
> Signed-off-by: Maik Brenke <maik.brenke@continental-corporation.com><br>
<br>
Thanks for this new iteration. There are still some formatting issues,<br>
but the most important issue is that it doesn't build.<br>
<br>
The following defconfig:<br>
<br>
BR2_arm=y<br>
BR2_TOOLCHAIN_EXTERNAL=y<br>
BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y<br>
BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y<br>
BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm-full-2018.05.tar.bz2"<br>
BR2_TOOLCHAIN_EXTERNAL_GCC_4_9=y<br>
BR2_TOOLCHAIN_EXTERNAL_HEADERS_4_1=y<br>
BR2_TOOLCHAIN_EXTERNAL_LOCALE=y<br>
# BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set<br>
BR2_TOOLCHAIN_EXTERNAL_CXX=y<br>
BR2_INIT_NONE=y<br>
BR2_SYSTEM_BIN_SH_NONE=y<br>
# BR2_PACKAGE_BUSYBOX is not set<br>
BR2_PACKAGE_VSOMEIP=y<br>
# BR2_TARGET_ROOTFS_TAR is not set<br>
<br>
Causes the following build failure:<br>
<br>
>>> vsomeip 2.10.21 Building<br>
PATH="/home/thomas/projets/buildroot/output/host/bin:/home/thomas/projets/buildroot/output/host/sbin:/home/thomas/sys/bin/:/usr/local/bin:/usr/bin:/bin:/home/thomas/.rvm/bin:/usr/local/sbin:/usr/sbin:/home/thomas/.rvm/bin:/home/thomas/sys/bin:/home/thomas/.gem/ruby/2.1.0/bin:/home/thomas/.rvm/bin:/home/thomas/projets/git-wrappers/" 
 /usr/bin/make -j5  -C /home/thomas/projets/buildroot/output/build/vsomeip-2.10.21/<br>
Scanning dependencies of target vsomeip<br>
[  1%] Building CXX object CMakeFiles/vsomeip.dir/implementation/endpoints/src/credentials.cpp.o<br>
[  2%] Building CXX object CMakeFiles/vsomeip.dir/implementation/endpoints/src/client_endpoint_impl.cpp.o<br>
[  4%] Building CXX object CMakeFiles/vsomeip.dir/implementation/endpoints/src/endpoint_definition.cpp.o<br>
[  5%] Building CXX object CMakeFiles/vsomeip.dir/implementation/endpoints/src/local_client_endpoint_impl.cpp.o<br>
[  7%] Building CXX object CMakeFiles/vsomeip.dir/implementation/endpoints/src/endpoint_impl.cpp.o<br>
In file included from /home/thomas/projets/buildroot/output/build/vsomeip-2.10.21/implementation/helper/boost/asio/datagram_socket_service_ext.hpp:33:0,<br>
                 from /home/thomas/projets/buildroot/output/build/vsomeip-2.10.21/implementation/helper/boost/asio/basic_datagram_socket_ext.hpp:24,<br>
                 from /home/thomas/projets/buildroot/output/build/vsomeip-2.10.21/implementation/helper/boost/asio/ip/udp_ext.hpp:20,<br>
                 from /home/thomas/projets/buildroot/output/build/vsomeip-2.10.21/implementation/endpoints/src/endpoint_impl.cpp:8:<br>
/home/thomas/projets/buildroot/output/build/vsomeip-2.10.21/implementation/helper/boost/asio/detail/reactive_socket_service_ext.hpp:29:43: fatal error: boost/asio/detail/addressof.hpp: No such file or directory<br>
 #include <boost/asio/detail/addressof.hpp><br>
                                           ^<br>
compilation terminated.<br>
make[4]: *** [CMakeFiles/vsomeip.dir/build.make:102: CMakeFiles/vsomeip.dir/implementation/endpoints/src/endpoint_impl.cpp.o] Error 1<br>
make[4]: *** Waiting for unfinished jobs....<br>
/home/thomas/projets/buildroot/output/build/vsomeip-2.10.21/implementation/endpoints/src/local_client_endpoint_impl.cpp: In member function ‘virtual void vsomeip::local_client_endpoint_impl::connect()’:<br>
/home/thomas/projets/buildroot/output/build/vsomeip-2.10.21/implementation/endpoints/src/local_client_endpoint_impl.cpp:128:64: error: ‘class boost::asio::basic_stream_socket<boost::asio::local::stream_protocol>’ has no member named ‘native’<br>
                         credentials::send_credentials(socket_->native(),<br>
                                                                ^<br>
make[4]: *** [CMakeFiles/vsomeip.dir/build.make:115: CMakeFiles/vsomeip.dir/implementation/endpoints/src/local_client_endpoint_impl.cpp.o] Error 1<br>
make[3]: *** [CMakeFiles/Makefile2:214: CMakeFiles/vsomeip.dir/all] Error 2<br>
make[2]: *** [Makefile:130: all] Error 2<br>
make[1]: *** [package/pkg-generic.mk:233: /home/thomas/projets/buildroot/output/build/vsomeip-2.10.21/.stamp_built] Error 2<br>
make: *** [Makefile:84: _all] Error 2<br>
<br>
I'll comment below some more issues.<br>
<br>
> diff --git a/DEVELOPERS b/DEVELOPERS<br>
> index 8d5ed19..54a0331 100644<br>
> --- a/DEVELOPERS<br>
> +++ b/DEVELOPERS<br>
> @@ -1258,6 +1258,9 @@ F:        package/mpv/<br>
>  F:      package/rpi-firmware/<br>
>  F:      package/rpi-userland/<br>
> <br>
> +N:     Maik Brenke, <maik.brenke@continental-corporation.com><br>
> +F:     package/vsomeip/<br>
<br>
Indentation is wrong: one tab should be used between the field name and<br>
their values.<br>
<br>
> +<br>
>  N:      Mamatha Inamdar <mamatha4@linux.vnet.ibm.com><br>
>  F:      package/nvme/<br>
> <br>
> diff --git a/package/Config.in b/package/Config.in<br>
> index 712e360..7ebb739 100644<br>
> --- a/package/Config.in<br>
> +++ b/package/Config.in<br>
> @@ -1582,6 +1582,7 @@ menu "Networking"<br>
>          source "package/sofia-sip/Config.in"<br>
>          source "package/thrift/Config.in"<br>
>          source "package/usbredir/Config.in"<br>
> +       source "package/vsomeip/Config.in"<br>
<br>
Indentation is wrong: use one tab. Perhaps it's because you didn't send<br>
your patch with "git send-email".<br>
<br>
> diff --git a/package/vsomeip/Config.in b/package/vsomeip/Config.in<br>
> new file mode 100644<br>
> index 0000000..7244c26<br>
> --- /dev/null<br>
> +++ b/package/vsomeip/Config.in<br>
> @@ -0,0 +1,22 @@<br>
> +config BR2_PACKAGE_VSOMEIP<br>
> +       bool "vsomeip"<br>
<br>
All over this file, the indentation is wrong: one need to use one tab.<br>
<br>
> +       depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8<br>
> +       depends on BR2_INSTALL_LIBSTDCPP<br>
> +       depends on BR2_TOOLCHAIN_HAS_THREADS # boost<br>
> +       depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS<br>
<br>
This option doesn't exist, so with dependency, the vsomeip package can<br>
never be selected. I'm wondering how you tested it.<br>
<br>
> +       select BR2_PACKAGE_BOOST<br>
> +       select BR2_PACKAGE_BOOST_SYSTEM<br>
> +       select BR2_PACKAGE_BOOST_THREAD<br>
> +       select BR2_PACKAGE_BOOST_LOG<br>
> +       help<br>
> +         The vsomeip stack implements the Scalable service-Oriented<br>
> +         MiddlewarE over IP (SOME/IP)) protocol (<a href="http://some-ip.com/" id="LPlnk326044" class="OWAAutoLink" previewremoved="true">http://some-ip.com/</a>).<br>
> +         The stack consists out of:<br>
> +          * a shared library for SOME/IP (`libvsomeip.so`)<br>
> +          * a second shared library for SOME/IP's service discovery<br>
> +            (`libvsomeip-sd.so`) which is loaded during runtime if<br>
> +            the service discovery is enabled.<br>
<br>
One blank line needed here.<br>
<br>
> +         <a href="https://github.com/GENIVI/vsomeip" id="LPlnk133437" class="OWAAutoLink" previewremoved="true">
https://github.com/GENIVI/vsomeip</a><br>
<br>
And another one here.<br>
<br>
> +comment "vsomeip needs a toolchain w/ C++, threads, gcc >= 4.8"<br>
> +       depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS<br>
<br>
Again, this option doesn't exist.<br>
<br>
> +       depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8<br>
<br>
Please split this long line.<br>
<br>
> diff --git a/package/vsomeip/vsomeip.mk b/package/vsomeip/vsomeip.mk<br>
> new file mode 100644<br>
> index 0000000..aebf707<br>
> --- /dev/null<br>
> +++ b/package/vsomeip/vsomeip.mk<br>
> @@ -0,0 +1,13 @@<br>
> +################################################################################<br>
> +#<br>
> +# vsomeip<br>
> +#<br>
> +################################################################################<br>
<br>
Please add one blank line here.<br>
<br>
> +VSOMEIP_VERSION = 2.10.21<br>
> +VSOMEIP_SITE = $(call github,GENIVI,vsomeip,$(VSOMEIP_VERSION))<br>
> +VSOMEIP_LICENSE = MPL-2.0<br>
> +VSOMEIP_LICENSE_FILES = LICENSE<br>
> +<br>
> +VSOMEIP_DEPENDENCIES = boost<br>
> +<br>
> +$(eval $(cmake-package))<br>
<br>
I had fixed all the formatting issues, but then stumbled across the<br>
build failure, so I gave up. Could you fix those issues, and send an<br>
updated version ?<br>
<br>
Thanks!<br>
<br>
Thomas<br>
-- <br>
Thomas Petazzoni, CTO, Bootlin<br>
Embedded Linux and Kernel engineering<br>
<a href="https://bootlin.com" id="LPlnk275802" class="OWAAutoLink" previewremoved="true">https://bootlin.com</a><br>
</div>
</span></font></div>
</div>
</div>
</body>
</html>