<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr">Le ven. 28 déc. 2018 à 01:58, Adrian Perez de Castro <<a href="mailto:aperez@igalia.com">aperez@igalia.com</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello,<br>
<br>
Quick review here...<br>
<br>
On Sun, 23 Dec 2018 16:48:44 +0100, Francois Perrad <<a href="mailto:fperrad@gmail.com" target="_blank">fperrad@gmail.com</a>> wrote:<br>
<br>
> Signed-off-by: Francois Perrad <<a href="mailto:francois.perrad@gadz.org" target="_blank">francois.perrad@gadz.org</a>><br>
> ---<br>
>  DEVELOPERS                                 |  1 +<br>
>  package/Config.in                          |  1 +<br>
>  package/wpebackend-fdo/Config.in           | 17 +++++++++++++++++<br>
>  package/wpebackend-fdo/wpebackend-fdo.hash |  7 +++++++<br>
>  package/wpebackend-fdo/<a href="http://wpebackend-fdo.mk" rel="noreferrer" target="_blank">wpebackend-fdo.mk</a>   | 15 +++++++++++++++<br>
>  5 files changed, 41 insertions(+)<br>
>  create mode 100644 package/wpebackend-fdo/Config.in<br>
>  create mode 100644 package/wpebackend-fdo/wpebackend-fdo.hash<br>
>  create mode 100644 package/wpebackend-fdo/<a href="http://wpebackend-fdo.mk" rel="noreferrer" target="_blank">wpebackend-fdo.mk</a><br>
> <br>
> diff --git a/DEVELOPERS b/DEVELOPERS<br>
> index 705842310..93a2bf5ad 100644<br>
> --- a/DEVELOPERS<br>
> +++ b/DEVELOPERS<br>
> @@ -828,6 +828,7 @@ F:        package/qemu/<br>
>  F:   package/sdl2_mixer/<br>
>  F:   package/sdl2_net/<br>
>  F:   package/tekui/<br>
> +F:   package/wpebackend-fdo/<br>
>  F:   package/wsapi-fcgi/<br>
>  F:   package/wsapi-xavante/<br>
>  F:   utils/scancpan<br>
> diff --git a/package/Config.in b/package/Config.in<br>
> index 7615c5853..e8a676ab0 100644<br>
> --- a/package/Config.in<br>
> +++ b/package/Config.in<br>
> @@ -1302,6 +1302,7 @@ menu "Graphics"<br>
>       source "package/webkitgtk/Config.in"<br>
>       source "package/webp/Config.in"<br>
>       source "package/woff2/Config.in"<br>
> +     source "package/wpebackend-fdo/Config.in"<br>
>       source "package/zbar/Config.in"<br>
>       source "package/zxing-cpp/Config.in"<br>
>  endmenu<br>
> diff --git a/package/wpebackend-fdo/Config.in b/package/wpebackend-fdo/Config.in<br>
> new file mode 100644<br>
> index 000000000..9025834e1<br>
> --- /dev/null<br>
> +++ b/package/wpebackend-fdo/Config.in<br>
> @@ -0,0 +1,17 @@<br>
> +comment "wpebackend-fdo needs an OpenEGL-capable backend"<br>
> +     depends on !BR2_PACKAGE_HAS_LIBEGL<br>
> +<br>
<br>
The dependency line for the comment needs to be updated to be the reverse<br>
of the list of dependencies for the BR2_PACKAGE_WPEBACKEND_FDO symbol below.<br>
<br>
Also, the comment text should follow the Buildroot style:<br>
<br>
    foo needs a toolchain w/ featA, featB, featC<br>
<br>
(There's more details about this in the Buildroot manual, which you can find<br>
at <a href="https://buildroot.org/downloads/manual/manual.html" rel="noreferrer" target="_blank">https://buildroot.org/downloads/manual/manual.html</a>)<br>
<br>
> +config BR2_PACKAGE_WPEBACKEND_FDO<br>
> +     bool "wpebackend-fdo"<br>
> +     depends on !BR2_STATIC_LIBS # dlfcn.h<br>
> +     depends on BR2_TOOLCHAIN_HAS_THREADS # wayland<br>
> +     depends on BR2_USE_WCHAR # gettext<br>
> +     depends on BR2_USE_MMU # fork()<br>
<br>
The BR2_USE_MMU belongs in the “wpewebkit” package (the backend itself does<br>
no forking), and should not be needed here.<br>
<br>
The BR2_USE_WCHAR dependency should not be needed here, as gettext is not<br>
required nor used by this package, neither it is needed by “wayland” nor<br>
“libxkbcommon”.<br>
<br></blockquote><div><br></div><div>These two dependencies comes from LIBGLIB2<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> +     depends on BR2_PACKAGE_HAS_LIBEGL<br>
> +     select BR2_PACKAGE_LIBGLIB2<br>
> +     select BR2_PACKAGE_LIBWPE<br>
> +     select BR2_PACKAGE_WAYLAND<br>
> +     help<br>
> +       WPE's backend based on a <a href="http://freedesktop.org" rel="noreferrer" target="_blank">freedesktop.org</a> stack.<br>
> +<br>
> +       <a href="https://wpewebkit.org/" rel="noreferrer" target="_blank">https://wpewebkit.org/</a><br>
> diff --git a/package/wpebackend-fdo/wpebackend-fdo.hash b/package/wpebackend-fdo/wpebackend-fdo.hash<br>
> new file mode 100644<br>
> index 000000000..6ebfcf335<br>
> --- /dev/null<br>
> +++ b/package/wpebackend-fdo/wpebackend-fdo.hash<br>
> @@ -0,0 +1,7 @@<br>
> +# From <a href="https://wpewebkit.org/releases/wpebackend-fdo-1.1.0.tar.xz.sums" rel="noreferrer" target="_blank">https://wpewebkit.org/releases/wpebackend-fdo-1.1.0.tar.xz.sums</a><br>
> +md5 dc852a6cafaf4b6392dcb91e36cd7abb wpebackend-fdo-1.1.0.tar.xz<br>
> +sha1 688377f441e19273fe2b44c0a2ea9da149f97fa4 wpebackend-fdo-1.1.0.tar.xz<br>
> +sha256 f6c72130d16e50860cb83eb0f6e109c76f1826d2c6bee39025fb3651941761e7 wpebackend-fdo-1.1.0.tar.xz<br>
> +<br>
> +# Hashes for license files:<br>
> +sha256 c9f6803371047fad3e72200ec6cd226329a5ee08ac61104c8211c2761fb46825 COPYING<br>
> diff --git a/package/wpebackend-fdo/<a href="http://wpebackend-fdo.mk" rel="noreferrer" target="_blank">wpebackend-fdo.mk</a> b/package/wpebackend-fdo/<a href="http://wpebackend-fdo.mk" rel="noreferrer" target="_blank">wpebackend-fdo.mk</a><br>
> new file mode 100644<br>
> index 000000000..b62e710a9<br>
> --- /dev/null<br>
> +++ b/package/wpebackend-fdo/<a href="http://wpebackend-fdo.mk" rel="noreferrer" target="_blank">wpebackend-fdo.mk</a><br>
> @@ -0,0 +1,15 @@<br>
> +################################################################################<br>
> +#<br>
> +# wpebackend-fdo<br>
> +#<br>
> +################################################################################<br>
> +<br>
> +WPEBACKEND_FDO_VERSION = 1.1.0<br>
<br>
As with libwpe, please use version 1.0.0 here.<br>
<br>
> +WPEBACKEND_FDO_SITE = <a href="http://wpewebkit.org/releases" rel="noreferrer" target="_blank">http://wpewebkit.org/releases</a><br>
> +WPEBACKEND_FDO_SOURCE = wpebackend-fdo-$(WPEBACKEND_FDO_VERSION).tar.xz<br>
> +WPEBACKEND_FDO_INSTALL_STAGING = YES<br>
> +WPEBACKEND_FDO_LICENSE = BSD-2-Clause<br>
> +WPEBACKEND_FDO_LICENSE_FILES = COPYING<br>
> +WPEBACKEND_FDO_DEPENDENCIES = libglib2 libwpe wayland<br>
<br>
This is missing “libegl” here.<br>
<br></blockquote><div><br></div><div>libegl is not needed here, libegl is already a dependency of libwpe.</div><div><br></div><div>François<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> +$(eval $(cmake-package))<br>
> -- <br>
> 2.17.1<br>
<br>
<br>
-Adrián<br>
_______________________________________________<br>
buildroot mailing list<br>
<a href="mailto:buildroot@busybox.net" target="_blank">buildroot@busybox.net</a><br>
<a href="http://lists.busybox.net/mailman/listinfo/buildroot" rel="noreferrer" target="_blank">http://lists.busybox.net/mailman/listinfo/buildroot</a><br>
</blockquote></div></div>