<div dir="ltr">Dear Thomas,<br><div class="gmail_extra"><br><div class="gmail_quote">2018-06-26 9:31 GMT+02:00 Thomas Petazzoni <span dir="ltr"><<a href="mailto:thomas.petazzoni@bootlin.com" target="_blank">thomas.petazzoni@bootlin.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br>
<br>
Thanks for this new iteration!<br>
<span class=""><br>
On Tue, 26 Jun 2018 00:02:37 +0200, Fabrice Fontaine wrote:<br>
<br>
> config BR2_PACKAGE_BOOST_FIBER<br>
> bool "boost-fiber"<br>
> + depends on BR2_PACKAGE_BOOST_CONTEXT_<wbr>ARCH_SUPPORTS<br>
> depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL<br>
> # mips support uses the "pause" instruction, only available<br>
> # since mips32r2/mips64r2.<br>
> depends on !BR2_MIPS_CPU_MIPS32 && !BR2_MIPS_CPU_MIPS64<br>
> + depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_<wbr>64735 # boost-context<br>
> depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_<wbr>85180<br>
> + select BR2_PACKAGE_BOOST_CONTEXT<br>
> help<br>
> C++11 userland threads library.<br>
> <br>
> comment "boost-fiber needs a toolchain w/ NPTL"<br>
> + depends on BR2_PACKAGE_BOOST_CONTEXT_<wbr>ARCH_SUPPORTS<br>
> depends on !BR2_TOOLCHAIN_HAS_THREADS_<wbr>NPTL<br>
> <br>
> +comment "boost-fiber needs a toolchain not affected by GCC bug 64735"<br>
> + depends on BR2_PACKAGE_BOOST_CONTEXT_<wbr>ARCH_SUPPORTS<br>
> + depends on BR2_TOOLCHAIN_HAS_GCC_BUG_<wbr>64735<br>
> +<br>
> comment "boost-fiber needs a toolchain not affected by GCC bug 85180"<br>
> + depends on BR2_PACKAGE_BOOST_CONTEXT_<wbr>ARCH_SUPPORTS<br>
> depends on BR2_TOOLCHAIN_HAS_GCC_BUG_<wbr>85180<br>
<br>
</span>Perhaps a single comment for the gcc bugs is enough, i.e:<br>
<br>
comment "boost-fiber needs a toolchain not affected by GCC bugs 64735, 85180"<br>
<br>
if you agree, no need to respin just for this change, we can fix it<br>
when applying.<br></blockquote><div>I agree, you can update before applying, thanks.<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Thanks,<br>
<br>
Thomas<br>
<span class="HOEnZb"><font color="#888888">-- <br>
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)<br>
Embedded Linux and Kernel engineering<br>
<a href="https://bootlin.com" rel="noreferrer" target="_blank">https://bootlin.com</a><br>
</font></span></blockquote></div>Best Regards,<br><br></div><div class="gmail_extra">Fabrice<br></div></div>