<div dir="ltr">Dear Thomas,<br><div class="gmail_extra"><br><div class="gmail_quote">2018-06-04 23:04 GMT+02:00 Thomas Petazzoni <span dir="ltr"><<a href="mailto:thomas.petazzoni@bootlin.com" target="_blank">thomas.petazzoni@bootlin.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br>
<span class=""><br>
On Sun,  3 Jun 2018 10:11:33 +0200, Fabrice Fontaine wrote:<br>
> Replace functions with ones that succeed or die with lexical scope<br>
> <br>
> <a href="https://metacpan.org/release/autodie" rel="noreferrer" target="_blank">https://metacpan.org/release/<wbr>autodie</a><br>
> <br>
> Signed-off-by: Fabrice Fontaine <<a href="mailto:fontaine.fabrice@gmail.com">fontaine.fabrice@gmail.com</a>><br>
> ---<br>
>  package/perl-autodie/perl-<wbr>autodie.hash |  6 ++++++<br>
>  package/perl-autodie/<a href="http://perl-autodie.mk" rel="noreferrer" target="_blank">perl-<wbr>autodie.mk</a>   | 13 +++++++++++++<br>
>  2 files changed, 19 insertions(+)<br>
>  create mode 100644 package/perl-autodie/perl-<wbr>autodie.hash<br>
>  create mode 100644 package/perl-autodie/<a href="http://perl-autodie.mk" rel="noreferrer" target="_blank">perl-<wbr>autodie.mk</a><br>
<br>
</span>This series doesn't fix the problem for me. Indeed, whois seems to be<br>
using /usr/bin/perl explicitly, so it doesn't find the perl-autodie<br>
built by Buildroot:<br>
<br>
>>> host-perl-autodie 2.29 Extracting<br>
>>> host-perl-autodie 2.29 Patching<br>
>>> host-perl-autodie 2.29 Configuring<br>
>>> host-perl-autodie 2.29 Building<br>
>>> host-perl-autodie 2.29 Installing to host directory<br>
>>> whois 5.3.0 Extracting<br>
/home/buildroot/output/host/<wbr>bin/xzcat /home/buildroot/buildroot/dl/<wbr>whois/whois_5.3.0.tar.xz | /home/buildroot/output/host/<wbr>bin/tar --strip-components=1 -C /home/buildroot/output/build/<wbr>whois-5.3.0   -xf -<br>
>>> whois 5.3.0 Patching<br>
>>> whois 5.3.0 Configuring<br>
>>> whois 5.3.0 Building<br>
PATH="/home/buildroot/output/<wbr>host/bin:/home/buildroot/<wbr>output/host/sbin:/usr/local/<wbr>sbin:/usr/local/bin:/usr/sbin:<wbr>/usr/bin:/sbin:/bin" /usr/bin/make -j5 CC="/home/buildroot/output/<wbr>host/bin/arm-linux-gcc" CFLAGS="-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os " LIBS="" Makefile.depend whois mkpasswd -C /home/buildroot/output/build/<wbr>whois-5.3.0<br>
/home/buildroot/output/host/<wbr>bin/arm-linux-gcc   -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os  -MM -MG *.c > Makefile.depend<br>
make[2]: 'Makefile.depend' is up to date.<br>
/usr/bin/perl <a href="http://make_version_h.pl" rel="noreferrer" target="_blank">make_version_h.pl</a> debian/changelog > version.h<br>
/usr/bin/perl <a href="http://make_ip_del.pl" rel="noreferrer" target="_blank">make_ip_del.pl</a> < ip_del_list > ip_del.h<br>
/usr/bin/perl <a href="http://make_ip6_del.pl" rel="noreferrer" target="_blank">make_ip6_del.pl</a> < ip6_del_list > ip6_del.h<br>
/usr/bin/perl <a href="http://make_as_del.pl" rel="noreferrer" target="_blank">make_as_del.pl</a> < as_del_list > as_del.h<br>
/usr/bin/perl <a href="http://make_as32_del.pl" rel="noreferrer" target="_blank">make_as32_del.pl</a> < as32_del_list > as32_del.h<br>
Can't locate <a href="http://autodie.pm" rel="noreferrer" target="_blank">autodie.pm</a> in @INC (you may need to install the autodie module) (@INC contains: /home/buildroot/output/host/<wbr>lib/perl /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at <a href="http://make_version_h.pl" rel="noreferrer" target="_blank">make_version_h.pl</a> line 5.<br>
BEGIN failed--compilation aborted at <a href="http://make_version_h.pl" rel="noreferrer" target="_blank">make_version_h.pl</a> line 5.<br>
make[2]: *** [Makefile:82: version.h] Error 2<br>
make[2]: *** Deleting file 'version.h'<br>
make[2]: *** Waiting for unfinished jobs....<br>
make[1]: *** [package/<a href="http://pkg-generic.mk:232" rel="noreferrer" target="_blank">pkg-generic.mk:232</a>: /home/buildroot/output/build/<wbr>whois-5.3.0/.stamp_built] Error 2<br>
make: *** [Makefile:16: _all] Error 2<br>
<br>
The second issue that I have is I'm not sure we want to add host-perl<br>
as a dependency of whois (and that's what your series is indirectly<br>
doing). host-perl is a pretty heavy dependency. I see three<br>
possibilities here:<br>
<br>
 - Keep it as you do, with perl-autodie using the host-perl-package<br>
   infrastructure, which means adding a host-perl dependency to the<br>
   dependency chain of whois.<br>
<br>
 - Implement perl-autodie like libxml-parser-perl, i.e explicitly avoid<br>
   using host-perl-package to avoid the host-perl dependency.<br>
<br>
 - Add a requirement on perl-autodie to be installed system-wide in<br>
   support/dependencies/<wbr>dependencies.sh, like we're already doing for a<br>
   few other Perl packages.<br></blockquote>Second or third solution are definitely better than first one. Which one do yo prefer?<br>Perhaps, the second option is better, I don't know if all our users run the dependencies.sh script?<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Best regards,<br>
<br>
Thomas<br>
<span class="HOEnZb"><font color="#888888">-- <br>
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)<br>
Embedded Linux and Kernel engineering<br>
<a href="https://bootlin.com" rel="noreferrer" target="_blank">https://bootlin.com</a><br>
</font></span></blockquote></div>Best Regards,<br><br></div><div class="gmail_extra">Fabrice<br></div></div>