<div dir="ltr">OK, thanks again. Though I still don't see the patch on next... DId you apply it?<div><br></div><div>Asaf.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Mar 2, 2018 at 10:38 AM, Arnout Vandecappelle <span dir="ltr"><<a href="mailto:arnout@mind.be" target="_blank">arnout@mind.be</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Hi Asaf,<br>
<span class=""><br>
On 26-02-18 20:20, Asaf Kahlon wrote:<br>
> Hi Arnout, thanks for the productive comments.<br>
> I fixed all, but didn't change CZMQ_AUTORECONF because it seems all the<br>
> autotools-related files were generated and expect autotools version of 1.14 and<br>
> can't be compiled with 1.15.<br>
<br>
</span> This statement doesn't make sense to me. But I understand why it is needed, see<br>
below.<br>
<span class=""><br>
> I uploaded a new patch here. Tell me if there's something else you want to change.<br>
<br>
</span> Thank you for that. However, you should still submit it as a proper patch in a<br>
separate e-mail, using git send-email (not just pasting it in a mail). If you<br>
send it like this, it gets incorrectly line-wrapped and can't be applied.<br>
<br>
> Signed-off-by: Asaf Kahlon <<a href="mailto:asafka7@gmail.com">asafka7@gmail.com</a> <mailto:<a href="mailto:asafka7@gmail.com">asafka7@gmail.com</a>>><br>
<br>
If you want to keep me in Cc of new versions, you can add here a line:<br>
<br>
Cc: Arnout Vandecappelle <<a href="mailto:arnout@mind.be">arnout@mind.be</a>><br>
<br>
and git send-email will also send it to me directly.<br>
<br>
> ---<br>
<br>
The additional remarks (i.e. "I fixed all comments, but didn't change...") you<br>
can put directly in the git commit message, here, below the --- line. That way,<br>
they will be in the mail but will not be included in the final git history.<br>
<br>
> package/czmq/czmq.hash | 6 +++++-<br>
> package/czmq/<a href="http://czmq.mk" rel="noreferrer" target="_blank">czmq.mk</a> <<a href="http://czmq.mk" rel="noreferrer" target="_blank">http://czmq.mk</a>> | 10 ++--------<br>
<span class="">> 2 files changed, 7 insertions(+), 9 deletions(-)<br>
><br>
> diff --git a/package/czmq/czmq.hash b/package/czmq/czmq.hash<br>
> index 526ea594b9..c0a7176f8d 100644<br>
> --- a/package/czmq/czmq.hash<br>
> +++ b/package/czmq/czmq.hash<br>
> @@ -1,2 +1,6 @@<br>
> +# From <a href="https://github.com/zeromq/czmq/releases" rel="noreferrer" target="_blank">https://github.com/zeromq/<wbr>czmq/releases</a><br>
> +md5 d29baef1079f19a2c6a360eb6be984<wbr>f8 czmq-4.1.0.tar.gz<br>
> +sha1 1d201a87205811367f7c92cbbd36a8<wbr>99edda68bf czmq-4.1.0.tar.gz<br>
> # Locally calculated<br>
> -sha256 5c76de41f736f0c059e0b26174ef99<wbr>200f2aba2fa38333683dbe4944b2f8<wbr>0555<br>
> czmq-<wbr>5205ec201e97c3a652c17eb86b18b7<wbr>0350b54512.tar.gz<br>
> +sha256 3befa35b4886b5298e8329b4f0aa5b<wbr>b9bde0e7439bd3c5c53295cb988371<wbr>fc11<br>
> czmq-4.1.0.tar.gz<br>
> +sha256 1f256ecad192880510e84ad60474ea<wbr>b7589218784b9a50bc7ceee34c2b91<wbr>f1d5 LICENCE<br>
</span>> diff --git a/package/czmq/<a href="http://czmq.mk" rel="noreferrer" target="_blank">czmq.mk</a> <<a href="http://czmq.mk" rel="noreferrer" target="_blank">http://czmq.mk</a>> b/package/czmq/<a href="http://czmq.mk" rel="noreferrer" target="_blank">czmq.mk</a><br>
> <<a href="http://czmq.mk" rel="noreferrer" target="_blank">http://czmq.mk</a>><br>
> index 5305789d7a..3c07845d9c 100644<br>
> --- a/package/czmq/<a href="http://czmq.mk" rel="noreferrer" target="_blank">czmq.mk</a> <<a href="http://czmq.mk" rel="noreferrer" target="_blank">http://czmq.mk</a>><br>
> +++ b/package/czmq/<a href="http://czmq.mk" rel="noreferrer" target="_blank">czmq.mk</a> <<a href="http://czmq.mk" rel="noreferrer" target="_blank">http://czmq.mk</a>><br>
<span class="">> @@ -4,8 +4,8 @@<br>
> #<br>
> #############################<wbr>##############################<wbr>#####################<br>
> <br>
> -CZMQ_VERSION = 5205ec201e97c3a652c17eb86b18b7<wbr>0350b54512<br>
> -CZMQ_SITE = $(call github,zeromq,czmq,$(CZMQ_<wbr>VERSION))<br>
> +CZMQ_VERSION = 4.1.0<br>
> +CZMQ_SITE = <a href="https://github.com/zeromq/czmq/releases/download/v$(CZMQ_VERSION)" rel="noreferrer" target="_blank">https://github.com/zeromq/<wbr>czmq/releases/download/v$(<wbr>CZMQ_VERSION)</a><br>
> <br>
> # Autoreconf required as we use the git tree<br>
<br>
</span> If autoreconf really is required, then this comment has to change, since now we<br>
are no longer using the git tree but we're using a tarball that does contain the<br>
configure script. However, now I see why it is needed. So change this comment into:<br>
<br>
# 0001-configure.ac-remove-<wbr>Werror.patch touches <a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
<br>
I have made this small modification and applied to next, thanks! So there is no<br>
need to resubmit now.<br>
<br>
Regards,<br>
Arnout<br>
<span class=""><br>
> CZMQ_AUTORECONF = YES<br>
> @@ -18,10 +18,4 @@ CZMQ_LICENSE_FILES = LICENSE<br>
> # host-python, so disable asciidoc entirely.<br>
> CZMQ_CONF_ENV = ac_cv_prog_czmq_have_asciidoc=<wbr>no<br>
> <br>
> -define CZMQ_CREATE_CONFIG_DIR<br>
</span>> -mkdir -p $(@D)/config<br>
<span class="">> -endef<br>
> -<br>
> -CZMQ_POST_PATCH_HOOKS += CZMQ_CREATE_CONFIG_DIR<br>
> -<br>
> $(eval $(autotools-package))<br>
</span>[snip]<br>
<div class="HOEnZb"><div class="h5"><br>
--<br>
Arnout Vandecappelle arnout at mind be<br>
Senior Embedded Software Architect <a href="tel:%2B32-16-286500" value="+3216286500">+32-16-286500</a><br>
Essensium/Mind <a href="http://www.mind.be" rel="noreferrer" target="_blank">http://www.mind.be</a><br>
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven<br>
LinkedIn profile: <a href="http://www.linkedin.com/in/arnoutvandecappelle" rel="noreferrer" target="_blank">http://www.linkedin.com/in/<wbr>arnoutvandecappelle</a><br>
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF<br>
</div></div></blockquote></div><br></div>