<div dir="ltr">Thomas,<div>thank you for your suggestions.</div><div>Actually, it was confusing me (what to use as upstream) and I wished to write my concerns in the cover letter. But forgot to write it.<br></div><div><br>I'll send updated patch later today.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 22 July 2017 at 20:25, Thomas Petazzoni <span dir="ltr"><<a href="mailto:thomas.petazzoni@free-electrons.com" target="_blank">thomas.petazzoni@free-electrons.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br>
<span class=""><br>
On Fri, 21 Jul 2017 21:45:20 +0700, Alexey Roslyakov wrote:<br>
> Many of Broadcom BCM43XX WiFi/Bluetooth combo chips have pretty tricky initialization.<br>
> Broadcom patchram utility has been released to address the issue.<br>
><br>
> Signed-off-by: Alexey Roslyakov <<a href="mailto:alexey.roslyakov@gmail.com">alexey.roslyakov@gmail.com</a>><br>
<br>
</span>Thanks for this contribution! See a few comments below.<br>
<span class=""><br>
> diff --git a/DEVELOPERS b/DEVELOPERS<br>
> index 7b7c5ab4e6..45466591da 100644<br>
> --- a/DEVELOPERS<br>
> +++ b/DEVELOPERS<br>
> @@ -73,6 +73,9 @@ N:  Alexandre Esse <<a href="mailto:alexandre.esse.dev@gmail.com">alexandre.esse.dev@gmail.com</a>><br>
>  F:   package/kvazaar/<br>
>  F:   package/v4l2loopback/<br>
><br>
> +N:   Alexey Roslyakov <<a href="mailto:alexey.roslyakov@gmail.com">alexey.roslyakov@gmail.com</a>><br>
> +F:   package/brcm-patchram-plus<br>
<br>
</span>Please end the package path with a /, like all other entries in the<br>
DEVELOPERS file.<br>
<span class=""><br>
> diff --git a/package/brcm-patchram-plus/<wbr>Config.in b/package/brcm-patchram-plus/<wbr>Config.in<br>
> new file mode 100644<br>
> index 0000000000..f7df21d2b2<br>
> --- /dev/null<br>
> +++ b/package/brcm-patchram-plus/<wbr>Config.in<br>
> @@ -0,0 +1,6 @@<br>
> +config BR2_PACKAGE_BRCM_PATCHRAM_PLUS<br>
> +     bool "brcm-patchram-plus"<br>
> +     help<br>
> +             Utility's to configure and test Broadcom Bluetooth chips on Linux.<br>
> +<br>
> +             <a href="https://code.google.com/archive/p/broadcom-bluetooth/" rel="noreferrer" target="_blank">https://code.google.com/<wbr>archive/p/broadcom-bluetooth/</a><br>
<br>
</span>Indentation for the help text is one tab + two spaces. I would<br>
recommend you to run utils/check-package on your new package to catch<br>
such coding style issues.<br>
<span class=""><br>
> +BRCM_PATCHRAM_PLUS_VERSION = 0.1.1<br>
> +BRCM_PATCHRAM_PLUS_SOURCE = brcm-patchram-plus_$(BRCM_<wbr>PATCHRAM_PLUS_VERSION).tar.gz<br>
> +BRCM_PATCHRAM_PLUS_SITE = <a href="https://launchpad.net/ubuntu/+archive/primary/+files" rel="noreferrer" target="_blank">https://launchpad.net/ubuntu/+<wbr>archive/primary/+files</a><br>
<br>
</span>Perhaps using the git repository at<br>
<a href="https://chromium.googlesource.com/chromiumos/third_party/broadcom" rel="noreferrer" target="_blank">https://chromium.googlesource.<wbr>com/chromiumos/third_party/<wbr>broadcom</a> would<br>
be a more "official" upstream ?<br>
<span class=""><br>
> +define BRCM_PATCHRAM_PLUS_BUILD_CMDS<br>
> +     $(TARGET_CC) -o $(@D)/brcm_patchram_plus $(@D)/brcm_patchram_plus.c<br>
> +endef<br>
> +<br>
> +define BRCM_PATCHRAM_PLUS_INSTALL_<wbr>TARGET_CMDS<br>
> +     $(INSTALL) -D -m 0755 $(@D)/brcm_patchram_plus $(TARGET_DIR)/usr/bin/brcm_<wbr>patchram_plus<br>
> +endef<br>
<br>
</span>What about using the Makefile that comes inside the package ? At least<br>
in the Git repository I pointed to, there is a Makefile that seems<br>
suitable.<br>
<br>
Thanks!<br>
<br>
Thoma<br>
<span class="HOEnZb"><font color="#888888">--<br>
Thomas Petazzoni, CTO, Free Electrons<br>
Embedded Linux and Kernel engineering<br>
<a href="http://free-electrons.com" rel="noreferrer" target="_blank">http://free-electrons.com</a><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">With best regards,<br>  Alexey Roslyakov<br>Email: <a href="mailto:alexey.roslyakov@gmail.com" target="_blank">alexey.roslyakov@gmail.com</a><br></div></div>
</div>