Thomas,<br> I got the Debian patch routine from the cvs package, when I was converting it. I just figured that there was some type of formatting issue in the debian patches that needed to be addressed. If I read it correctly, it looks like it strips any prefix from the name of the package to patch. I must confess, I'm not very good with sed. Is this something that doesn't need to be done? If so, just let me know, and I'll change the packages that are affected.<br>
As to the *_TOOLS_BUILD_CMDS issue, until now, I thought that the hooks were only available for the autotargets packages. I just re-read that section in the Usage and documentation page, and it looks like you can use the hooks in a gentargets package. I'll try it out, and change the packages that have that issue.<br>
<br>Martin<br><br><div class="gmail_quote">On Tue, Oct 5, 2010 at 2:17 AM, Thomas Petazzoni <span dir="ltr"><<a href="mailto:thomas.petazzoni@free-electrons.com">thomas.petazzoni@free-electrons.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Hello,<br>
<br>
Thanks Martin for doing all this conversion work, this is much<br>
appreciated!<br>
<div class="im"><br>
On Tue, 5 Oct 2010 01:22:34 -0700<br>
Martin Banky <<a href="mailto:martin.banky@gmail.com">martin.banky@gmail.com</a>> wrote:<br>
<br>
> +define INPUT_TOOLS_DEBIAN_PATCHES<br>
> + if [ -d $(@D)/debian/patches ]; then \<br>
> + (cd $(@D)/debian/patches && for i in *; \<br>
> + do $(SED) 's,^\+\+\+ .*joystick-$(INPUT_TOOLS_VERSION)/,+++ joystick-$(INPUT_TOOLS_VERSION)/,' $$i; \<br>
<br>
</div>I have seen this in several of your patches, but I don't understand why<br>
it is here. There are several other packages that do apply the debian<br>
patches, but such a sed step is not needed.<br>
<div class="im"><br>
> +define INPUT_TOOLS_BUILD_CMDS<br>
> + $(INPUT_TOOLS_DEBIAN_PATCHES)<br>
<br>
</div>Even though it doesn't technically make any difference, I'd prefer to<br>
have this as a post-patch hook.<br>
<br>
Thanks!<br>
<br>
Thomas<br>
--<br>
<font color="#888888">Thomas Petazzoni, Free Electrons<br>
Kernel, drivers, real-time and embedded Linux<br>
development, consulting, training and support.<br>
<a href="http://free-electrons.com" target="_blank">http://free-electrons.com</a><br>
_______________________________________________<br>
buildroot mailing list<br>
<a href="mailto:buildroot@busybox.net">buildroot@busybox.net</a><br>
<a href="http://lists.busybox.net/mailman/listinfo/buildroot" target="_blank">http://lists.busybox.net/mailman/listinfo/buildroot</a><br>
</font></blockquote></div><br>